ImageStyle::getReplacementID missing from interface

This actually shows up in the phpstan report as well.

I think this might actually be a dead method as well so removing it might also be an option. It just proxies through to the storage method of the similar name(different capitalization) and using that might be the correct way of accomplishing this.

Looks good for the straightforward fix.

Will leave questions of the not strictly camelcacse code and possible code removal to committer review and RTBC this.

If it really isn't used we should deprecate it now instead of postponing that..

I didn't find usages in core. I didn't find one in contrib either. Did I miss a usage? Can someone check on that?

@quietone You are correct. I have also checked the usage of ImageStyle::getReplacementID, and I could not find any.

I think @quietone is right and we should deprecate this instead.

I’ve deprecated the getReplacementID() method after confirming it isn’t used in core or contrib, and I followed a similar approach to other deprecated methods. Moving this NR , Could you please review and let me know if anything needs to be updated or improved?

Thank you for the guidance!

Feedback appears to be addressed.

Thank you for the feedback , yes {@inheritDoc} is there so no need to add the deprecation here , i have checked other deprecated method also for same with {@inheritDoc}. i have updated here also.

The change record is incorrect here - it needs to talk about the method being added to the interface, not the deprecation that was removed from the MR.

Talked to catch to clarify and we don't really need to push the method to the interface at all since this is dead code and it just adds complexity.

I shuffled Shalini's code around to accomplish this. Also bumped code and CR to 11.3 as well as point the unlikely user that finds this to the method on the storage class that still has this functionality.

Looks good and the CR lines up.

Updated the proposed resolution which was still out of date.

Shouldn’t this have a deprecation @trigger_error anyway?

It should. Also updating the issue title for what's actually happening.