- Issue created by @neclimdul
- ๐บ๐ธUnited States neclimdul Houston, TX
This actually shows up in the phpstan report as well.
I think this might actually be a dead method as well so removing it might also be an option. It just proxies through to the storage method of the similar name(different capitalization) and using that might be the correct way of accomplishing this.
- First commit to issue fork.
- Merge request !10902Issue #3498540: Added method to ImageStyleInterface โ (Open) created by shalini_jha
- ๐บ๐ธUnited States neclimdul Houston, TX
Looks good for the straightforward fix.
Will leave questions of the not strictly camelcacse code and possible code removal to committer review and RTBC this.
- ๐ฎ๐ณIndia shalini_jha
@quietone You are correct. I have also checked the usage of ImageStyle::getReplacementID, and I could not find any.
- ๐ฌ๐งUnited Kingdom catch
I think @quietone is right and we should deprecate this instead.
- Status changed to Needs review
2 months ago 8:33am 24 April 2025 - ๐ฎ๐ณIndia shalini_jha
Iโve deprecated the getReplacementID() method after confirming it isnโt used in core or contrib, and I followed a similar approach to other deprecated methods. Moving this NR , Could you please review and let me know if anything needs to be updated or improved?
Thank you for the guidance!
- ๐ฎ๐ณIndia shalini_jha
Thank you for the feedback , yes {@inheritDoc} is there so no need to add the deprecation here , i have checked other deprecated method also for same with {@inheritDoc}. i have updated here also.
- ๐ฌ๐งUnited Kingdom catch
The change record is incorrect here - it needs to talk about the method being added to the interface, not the deprecation that was removed from the MR.
- ๐บ๐ธUnited States neclimdul Houston, TX
Talked to catch to clarify and we don't really need to push the method to the interface at all since this is dead code and it just adds complexity.
I shuffled Shalini's code around to accomplish this. Also bumped code and CR to 11.3 as well as point the unlikely user that finds this to the method on the storage class that still has this functionality.
- ๐ฌ๐งUnited Kingdom catch
Looks good and the CR lines up.
Updated the proposed resolution which was still out of date.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
Shouldnโt this have a deprecation @trigger_error anyway?
- ๐ฌ๐งUnited Kingdom catch
It should. Also updating the issue title for what's actually happening.