1.0.x Zoho ZeptoMail

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. main is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → . The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.

main will be a supported branch in future, but for the moment it is better not to use it. It is not wrong, but it is not completely supported on drupal.org.

2. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml zohozeptomail/

FILE: zohozeptomail/zohozeptomail.install
--------------------------------------------------------------------------------
FOUND 12 ERRORS AND 3 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------
  8 | WARNING | [x] Unused use statement
 39 | ERROR   | [x] Missing function doc comment
 51 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 51 | ERROR   | [x] Expected 1 space after closing parenthesis; found 0
 53 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 54 | ERROR   | [x] Whitespace found at end of line
 55 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 56 | WARNING | [ ] Unused variable $key.
 56 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 57 | WARNING | [ ] Unused variable $fromaddress.
 57 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 59 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 60 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 61 | ERROR   | [x] Whitespace found at end of line
 61 | ERROR   | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: zohozeptomail/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 360 characters
 24 | WARNING | Line exceeds 80 characters; contains 91 characters
 29 | WARNING | Line exceeds 80 characters; contains 95 characters
 30 | WARNING | Line exceeds 80 characters; contains 86 characters
 38 | WARNING | Line exceeds 80 characters; contains 131 characters
----------------------------------------------------------------------

FILE: zohozeptomail/zohozeptomail.info.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 8 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: zohozeptomail/src/Plugin/Mail/ZeptoMail.php
--------------------------------------------------------------------------------
FOUND 20 ERRORS AND 3 WARNINGS AFFECTING 20 LINES
--------------------------------------------------------------------------------
   8 | WARNING | [x] Unused use statement
  10 | WARNING | [x] Unused use statement
  10 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
  12 | ERROR   | [x] There must be one blank line after the last USE statement; 2 found;
  15 | ERROR   | [x] Missing class doc comment
  17 | ERROR   | [ ] Missing member variable doc comment
  19 | ERROR   | [ ] Missing member variable doc comment
  21 | ERROR   | [ ] Missing member variable doc comment
  23 | ERROR   | [x] Missing function doc comment
  64 | ERROR   | [x] Missing function doc comment
  94 | WARNING | [x] 'TODO handle attachment' should match the format '@todo Fix problem X here.'
  94 | ERROR   | [x] No space found before comment text; expected "// TODO handle attachment" but found "//TODO handle attachment"
  94 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
  98 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  99 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 100 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 101 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 10
 102 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 103 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 105 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 106 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 107 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 109 | ERROR   | [x] Line indented incorrectly; expected 5 spaces, found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: zohozeptomail/src/Form/ZeptoMailSettingsForm.php
--------------------------------------------------------------------------------
FOUND 8 ERRORS AND 1 WARNING AFFECTING 8 LINES
--------------------------------------------------------------------------------
  16 | ERROR   | [x] Whitespace found at end of line
  17 | ERROR   | [ ] Missing member variable doc comment
  20 | ERROR   | [x] Missing function doc comment
  20 | ERROR   | [x] Expected 1 blank line before function; 2 found
  54 | ERROR   | [x] Whitespace found at end of line
  69 | ERROR   | [x] Whitespace found at end of line
  81 | ERROR   | [x] Whitespace found at end of line
  88 | WARNING | [ ] Possible useless method overriding detected
 110 | ERROR   | [x] Whitespace found at end of line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: zohozeptomail/src/ZeptoMailHandler.php
--------------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 14 LINES
--------------------------------------------------------------------------------
  6 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
  9 | ERROR | [x] Missing class doc comment
 12 | ERROR | [ ] Missing member variable doc comment
 15 | ERROR | [ ] Missing member variable doc comment
 18 | ERROR | [ ] More than 2 empty lines are not allowed
 19 | ERROR | [x] Missing function doc comment
 19 | ERROR | [x] Expected 1 blank line before function; 3 found
 22 | ERROR | [x] Whitespace found at end of line
 23 | ERROR | [x] Expected 1 blank line after function; 2 found
 26 | ERROR | [x] Missing function doc comment
 28 | ERROR | [x] Expected 1 blank line after function; 2 found
 35 | ERROR | [x] Whitespace found at end of line
 35 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 38 | ERROR | [x] Expected 1 blank line after function; 3 found
 41 | ERROR | [ ] More than 2 empty lines are not allowed
 42 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

3. FILE: zohozeptomail.module

/**
 * @file
 * Tntegrate the third party Zoho ZeptoMail service with Drupal.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

Is the account used to create this application shared account?

I am closing this application, since there have not been any reply to my comment asking if the used account is shared.