- Issue created by @MrDaleSmith
- πΊπΈUnited States mradcliffe USA
It seems to me that mkalkbrenner/php-htmldiff-advanced is pretty much abandoned. I don't think the diff module should rely on it. Since it's GPL-2.0, the 2 classes could be brought into this module and the dependency changed to a recent version of caxy/php-htmldiff.
I think this should be elevated to Major since PHP 8.4 is supported by Drupal 11.
- πΊπΈUnited States mradcliffe USA
I guess on new installs it gets the new release so not Major. I think it could be a Minor to just ditch the extra dependency and bring in its classes into diff module.
It will remove the need for the hook_requirements, phpstan overrides, etc...
- Merge request !129Removes unsupported dependency by bringing in code into module β (Closed) created by mradcliffe
- πΊπΈUnited States phernand42
Would it be possible to update to 0.1.17? That release contains a fix that wold fix this issue.
https://www.drupal.org/project/diff/issues/3522755 π ($source) must not be empty Active
- πΊπΈUnited States mradcliffe USA
That makes sense, @phernand42. I updated the version, and I realized I kept the strict version in the original merge request, but I think it should be relaxed to
^0.1.17
or even^0.1
. - π¦πΊAustralia acbramley
Running
composer update drupal/diff -W
should be enough.Since the caxy library is a dependency of a dependency (
mkalkbrenner/php-htmldiff-advanced
) there's nothing else to do here. - Status changed to Closed: outdated
4 days ago 1:22pm 19 May 2025 - πΊπΈUnited States mradcliffe USA
That's disappointing. I don't think this module should be using an unsupported library, @acbramley.
- π¦πΊAustralia acbramley
@mradcliffe I agree, but the MR here was adding the library's code to the module which I don't want to support. We should find an alternative.