Required library has code deprecation

It seems to me that mkalkbrenner/php-htmldiff-advanced is pretty much abandoned. I don't think the diff module should rely on it. Since it's GPL-2.0, the 2 classes could be brought into this module and the dependency changed to a recent version of caxy/php-htmldiff.

I think this should be elevated to Major since PHP 8.4 is supported by Drupal 11.

I guess on new installs it gets the new release so not Major. I think it could be a Minor to just ditch the extra dependency and bring in its classes into diff module.

It will remove the need for the hook_requirements, phpstan overrides, etc...

Would it be possible to update to 0.1.17? That release contains a fix that wold fix this issue.

https://www.drupal.org/project/diff/issues/3522755 🐛 ($source) must not be empty Active

That makes sense, @phernand42. I updated the version, and I realized I kept the strict version in the original merge request, but I think it should be relaxed to ^0.1.17 or even ^0.1.

Running composer update drupal/diff -W should be enough.

Since the caxy library is a dependency of a dependency (mkalkbrenner/php-htmldiff-advanced) there's nothing else to do here.

acbramley → closed merge request !129

Thanks acbramley, that worked

That's disappointing. I don't think this module should be using an unsupported library, @acbramley.

@mradcliffe I agree, but the MR here was adding the library's code to the module which I don't want to support. We should find an alternative.