Event content type link field always has "external" icon

Per @ckrina at https://drupal.slack.com/archives/C07G41EUJP4/p1736344315627679?thread_t...

I don’t think it’s a good pattern to force someone to open something in a new window or tap, regardless of it being external or not. They should decide. And the icon should only appear if the link is going to open in a new window.

If there i no way to make that link external, then the icon doesn’t matter.

I'm taking care of this in the CSS at 📌 Implement designs for case study/project full page display within Olivero Active , since there's an external icon there, too.

So is this issue a duplicate?

No. It's an issue. But i'm fixing as part of the other MR. When that gets merged we can close this as fixed.

That icon means "external website" not "new window", so it looks correct in this context.
As noted, it's not considered good UX to open links in a new window. If people want to do that, they can choose to do so.

Just tested since 📌 Implement designs for case study/project full page display within Olivero Active was recently merged. Note that in both cases there's this class: button--external which is confusing from a DX perspective, but the CSS works as expected, and adds the icon if it's external. It doesn't redirect because that's not a best practice anymore as noted above.

External link

Internal link

Great! It's fixed. Love it when I get to mark things fixed without doing anything. Pretty rad.

Automatically closed - issue fixed for 2 weeks with no activity.