Add return type to hook_file_download implementations

Well other than hook help still :/ Maybe I will take another crack at that.

This looks pretty straightforward.

After apply the diff there are still more

(11.x)$ grep "fileDownload\\\\.* has no return" core/.phpstan-baseline.php
        'message' => '#^Method Drupal\\\\image\\\\Hook\\\\ImageHooks\\:\\:fileDownload\\(\\) has no return type specified\\.$#',
        'message' => '#^Method Drupal\\\\system\\\\Hook\\\\SystemHooks\\:\\:fileDownload\\(\\) has no return type specified\\.$#',

Fixed the two methods mentioned in #5, not sure how they were missed before.

Re #4:

Well other than hook help still

I mean those that don't already have an issue

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed conflict and re base this MR, re run the "grep "fileDownload\\\\.* has no return" core/.phpstan-baseline.php", and it is not showing any other list.So moving this back to NR.

Rebase seems fine.

Based on the issue and its summary, it seems that this change is related to updating the return type. But last commit is updating the comments ?

@oily, I agree those changes are out of scope for this type of issue.

@nicxvan Yes, it suddenly occurred to me before seeing #12 and #13 so I am now mindful to keep changes strictly within scope. I did the edits using online editor so tricky to revert right now. I agree best in a follow-up. But perhaps could permit on this occasion since the MR will not affect functionality since comments? Otherwise I will revert later.

I wouldn't revert unless a committer requests it, just keep it in mind for the future.

Yes, let's keep this is scope and only add the return type. So, yes remove the out of scope changes.

I have checked the MR, and the changes made in #11 were removed from the MR after the latest rebase. I can no longer find the comment-related changes in the MR. moving this back to NR.

Restoring status

@mstrelan, Thanks for making the changes to keep this in scope.

Left two comments concerning follow up work.

Committed 16db2d7 and pushed to 11.x.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.