- Issue created by @phenaproxima
- Merge request !387Issue #3497781: Add an XB recipe that is part of the project template β (Merged) created by phenaproxima
- πΊπΈUnited States effulgentsia
phenaproxima β credited effulgentsia β .
- πΊπΈUnited States phenaproxima Massachusetts
Crediting Pam and Alex for coming up with this idea.
- πΊπΈUnited States tim.plunkett Philadelphia
phenaproxima β credited tim.plunkett β .
- πΊπΈUnited States phenaproxima Massachusetts
Crediting myself for writing this thing, and @tim.plunkett for helping forge the absolute mad science concept of a Composer plugin that is also a Drupal recipe.
- π¬π§United Kingdom catch
So if I'm reading correctly, this will uninstall experience builder every time composer is about to update it, before it's actually updated.
However, at some point, XB is going to release a beta/rc/stable that supports an upgrade path.
How will Drupal CMS prevent this composer plugin from uninstalling XB again once the site is on that release? The plugin would have to be removed before updating to the first release that supports an upgrade path, but also before the next update from that release to the next one.
- πΊπΈUnited States phenaproxima Massachusetts
Why don't I just alter the plugin such that it only does its thing if you're updating from a pre-beta release to another pre-beta release?
- π¦πΊAustralia pameeela
This is amazing and terrifying and I love it but also don't feel comfortable being the one to RTBC it, hoping @tim.plunkett can give his signoff!
- πΊπΈUnited States phenaproxima Massachusetts
Assigning to @tim.plunkett for final review.
- πΊπΈUnited States tim.plunkett Philadelphia
Reviewed, happy with this. Mad science strikes again!
-
phenaproxima β
committed d4ff8054 on 1.x
Issue #3497781 by phenaproxima, pameeela, tim.plunkett, effulgentsia,...
-
phenaproxima β
committed d4ff8054 on 1.x
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x and cherry-picked to 1.0.x. Thanks all!
-
phenaproxima β
committed 6ae724dd on 1.0.x
Issue #3497781 by phenaproxima, pameeela, tim.plunkett, effulgentsia,...
-
phenaproxima β
committed 6ae724dd on 1.0.x
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Post-merge review to see how this managed to land β¦ wow β epic work, @phenaproxima! π
- π¬π§United Kingdom catch
There's no automated testing here, if there had been, it might have caught the 'stable release uninstall timebomb' found in #10. Also has this been manually tested with a composer update of experience builder?
- πΊπΈUnited States phenaproxima Massachusetts
Yes, I manually tested it between XB commits.
It could use automated testing but I decided not to block on that because this is so strategically important for us.