- Issue created by @dunx
- 🇺🇸United States phenaproxima Massachusetts
Moving this to Project Browser's issue queue, since this would presumably affect any site which used Project Browser with Gin.
- 🇺🇸United States JI_Gravityworks
jane_irwin → made their first commit to this issue’s fork.
- Merge request !805Set background-color attribute of .pb-detail-modal__sidebar to only apply when using light mode → (Open) created by JI_Gravityworks
- 🇺🇸United States JI_Gravityworks
I'm in the contrib room at Drupal MidCamp, and picked this as a quick fix. Tested in Light, Dark, and Auto mode.
- 🇺🇸United States JI_Gravityworks
Marking as Needs Review. Thanks for the patience with the extra comments.
- 🇬🇧United Kingdom dunx
Steps to test, using ddev locally:
- Installed last dev version of Drupal CMS.
- Enabled dark mode in gin admin theme.
- Visit project browser pages and click on a Recipe.
Still not accessible. Doesn't make any difference whether the Recipe is installed or not - that panel's text contrast is still very low.
- 🇬🇧United Kingdom dunx
Forgot to make the code change (that's an ex-dev for you!)... so all the above, plus the code change gives:
Which looks good to me. I reverted to light mode and that also still looks fine.