- Issue created by @darren oh
- Merge request !373Issue #3497485: Fix remaining duplication of batch jobs β (Closed) created by darren oh
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I tested this and it didn't work. Here's a video:
Let me know if I'm testing incorrectly.
- πΊπΈUnited States phenaproxima Massachusetts
Moving to the Recipe Installer Kit project, which is what contains the business logic of the installer.
- πΊπΈUnited States phenaproxima Massachusetts
So one major technical reason I'm not sure about this change is because we cannot safely anticipate what will be included in
RecipeRunner::toBatchOperations()
. There may well be things in there that don't cleanly compare, or that aren't serializable, or...etc. That unpredictability makes this somewhat dangerous, and I'm not sure the risk-to-reward ratio is favorable enough to proceed.Thoughts?
- πΊπΈUnited States darren oh Lakeland, Florida
We're doing a strict check, so the worst that could happen is a few duplicate batch jobs slip through.
- Merge request !4Issue #3497485: Fix remaining duplication of batch jobs β (Open) created by darren oh
- Status changed to Needs review
24 days ago 6:21pm 27 March 2025 - π³π΄Norway zaporylie
I discovered that most of the duplications I am seeing are coming from strict comparison when batch tasks are containing instances of Recipe object representing the same Recipe.