- Issue created by @swentel
- πΊπΈUnited States mradcliffe USA
Also it would be a good idea to fix up the use of dynamic properties:
Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerLocalizedTest::$adminUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 40 Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerLocalizedTest::$authenticatedUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 41 F Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerLocalizedTest::$adminUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 40 Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerLocalizedTest::$authenticatedUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 41 Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerTest::$adminUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 40 Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerTest::$authenticatedUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 41 F 2 / 2 (100%) Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerTest::$adminUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 40 Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerTest::$authenticatedUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 41
- πΊπΈUnited States mradcliffe USA
I'm pretty sure that we don't need to drupalLogout anymore before the test in webfingerResponseHelper:96.
Would it also be better to get a fresh
$page = $this->getSession()->getPage();
after eachdrupalGet
call? - π§πͺBelgium swentel
Would it also be better to get a fresh $page = $this->getSession()->getPage(); after each drupalGet call?
Seems to be fine, so leaving as is. Tests are green (apart from the current todo in localized)
- πΊπΈUnited States mradcliffe USA
Do you want to try checking if localize will pass now?
- π§πͺBelgium swentel
Fails locally as well, at least on D11 - will double check if I can fix it
- πΊπΈUnited States mradcliffe USA
Guess not. It was worth a shot :D
-
swentel β
committed a5b824c7 on 2.0.x
Issue #3496359: Fix fail in WebfingerTest.php
-
swentel β
committed a5b824c7 on 2.0.x
- π§πͺBelgium swentel
merged, opened another issue for the localized test