Fix fail in WebfingerTest.php

Created on 28 December 2024, about 2 months ago
πŸ“Œ Task
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium swentel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @swentel
  • πŸ‡ΊπŸ‡ΈUnited States mradcliffe USA

    Also it would be a good idea to fix up the use of dynamic properties:

    Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerLocalizedTest::$adminUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 40                                                                                                                                                                        
                                                                                                                                                                                                  
    Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerLocalizedTest::$authenticatedUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 41                                                                                                                                                                
    F                                                                                                                                                                                             
    Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerLocalizedTest::$adminUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 40                                                                                                                                                                        
                                                                                                                                                                                                  
    Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerLocalizedTest::$authenticatedUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 41
    
    Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerTest::$adminUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 40
    
    Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerTest::$authenticatedUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 41
    F                                                                  2 / 2 (100%)
    Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerTest::$adminUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 40
    
    Deprecated: Creation of dynamic property Drupal\Tests\webfinger\Functional\WebfingerTest::$authenticatedUser is deprecated in /var/www/html/modules/webfinger/tests/src/Functional/WebfingerTestBase.php on line 41
    
  • Merge request !5Fix tests β†’ (Merged) created by swentel
  • πŸ‡ΊπŸ‡ΈUnited States mradcliffe USA

    I'm pretty sure that we don't need to drupalLogout anymore before the test in webfingerResponseHelper:96.

    Would it also be better to get a fresh $page = $this->getSession()->getPage(); after each drupalGet call?

  • πŸ‡§πŸ‡ͺBelgium swentel

    Would it also be better to get a fresh $page = $this->getSession()->getPage(); after each drupalGet call?

    Seems to be fine, so leaving as is. Tests are green (apart from the current todo in localized)

  • πŸ‡ΊπŸ‡ΈUnited States mradcliffe USA

    Do you want to try checking if localize will pass now?

  • πŸ‡§πŸ‡ͺBelgium swentel

    Fails locally as well, at least on D11 - will double check if I can fix it

  • πŸ‡ΊπŸ‡ΈUnited States mradcliffe USA

    Guess not. It was worth a shot :D

  • Pipeline finished with Skipped
    about 2 months ago
    #380595
  • πŸ‡§πŸ‡ͺBelgium swentel

    merged, opened another issue for the localized test

Production build 0.71.5 2024