- Issue created by @danrod
- Merge request !17Issue #3495691: Fixed all PHP_CodeSniffer errors. → (Closed) created by divyansh.gupta
- 🇮🇳India divyansh.gupta Jaipur
I have made the required changes to remove all PHP_CodeSniffer errors,
Please review. - 🇨🇦Canada danrod Ottawa
I still see some issues when running the PHPUnit tests, could you check, please @divyansh.gupta ? https://git.drupalcode.org/issue/google_calendar_service-3495691/-/jobs/...
- 🇮🇳India divyansh.gupta Jaipur
divyansh.gupta → changed the visibility of the branch 3.0.x to hidden.
- 🇮🇳India divyansh.gupta Jaipur
divyansh.gupta → changed the visibility of the branch 3495691-fix-issues-reported to hidden.
- 🇮🇳India divyansh.gupta Jaipur
Hello @danrod,
Resolved the phpunit please review. - 🇨🇦Canada danrod Ottawa
Thanks @divyansh.gupta for fixing the PHPCS warnings, I still see some CSPELL and PHPSTAN issues, would you be able to check these? if not I can look on these today.
- 🇨🇦Canada danrod Ottawa
I fixed all the issues and all the tests passed OK this time, I'll test this in Drupal 10 and then I'll merge it to the 3.0.x branch: https://git.drupalcode.org/project/google_calendar_service/-/pipelines/3...
- 🇨🇦Canada danrod Ottawa
Tested on D10 with no issues, I'll mark this as "Fixed", I'll make a new release shortly, thanks @divyansh.gupta for your help !
-
danrod →
committed adcc2fe2 on 3.0.x authored by
divyansh.gupta →
Resolve #3495691 "Resolve phpcs errors"
-
danrod →
committed adcc2fe2 on 3.0.x authored by
divyansh.gupta →