Scroll limit broken has no effect in 2.x

Created on 23 December 2024, 29 days ago

Problem/Motivation

Just found out, that the "Scroll limit" option has no effect with 2.x!

Testing the same on a 1.x page works fine, so I think it's a library issue? Whatever value I enter, the banner always appears immediately.

Here's the GitHub issue with a related proposal to ensure the banner is always viewable: https://github.com/jfeltkamp/cookiesjsr/issues/40

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • 🇩🇪Germany jfeltkamp Hamburg

    Fixed scroll limit behavior.

    The scroll limit was handled from the preloader to avoid loading of heavy library.
    Now it moved into the main library where it is still making sense to avoid the "LCP" (largest meaningful content pain) loading slow.

    Also fixed behavior for not scrollable/short pages. Recalculating the scroll limit by take the max scroll height into account.

    Added to 2.x. Will be included >= 2.0.4

  • 🇩🇪Germany Anybody Porta Westfalica

    Thank you so much @jfeltkamp!! Great news before the new year! 🚀
    So we just need to update the JS lib!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024