Fix broken tests

If these tests where converted to XPath, changes in whitespace or attribute order would not cause them to fail.

I don't have the time to start rewriting tests. Any help is appreciated.

Base phpunit is now passing but the HTML changes subsequently broke previous minor. Max PHP seems to be failing due to deprecations in entity_print and potentially others (unless I'm not seeing the right errors).

I've started converting the problematic HTML assertions to using optionExists (as they mostly seem to be around select options) and I've tried reducing duplicated assertions (e.g in WebformElementTermReferenceTest) to reduce the maintenance overhead.

Ok, current and previous are passing. As far as I can tell we can't get a green max PHP run without other contrib modules fixing all their deprecations so I've allowed that to fail.

Thanks for the patch.

I don't understand why the changes to fputcsv() are needed. \\ is the default value for escape.

Thank you for fixing the broken tests. I am tempted to merge this and tag a beta release for Drupal CMS's sake. Webform is the only alpha release module being included in Drupal CMS.

@liam morland Are you okay with us merging and tagging a beta?

Yes, that makes sense.

I note that the merge request removes the "Unpublish term:2" test. Is there a reason that test is not updated like the others?

At a quick glance, none of the RTBC issues should be merged.

In that case, perhaps they should be marked postponed.

@liam morland

I don't understand why the changes to fputcsv() are needed. \\ is the default value for escape.

Check the previous max PHP runs, that parameter is required in PHP 8.4

I note that the merge request removes the "Unpublish term:2" test. Is there a reason that test is not updated like the others?

See line 86 of the test file, it looked like a fully duplicated block of test code.

I am good with the being merged. @liam morland Does this work for you?

Yes

Done! @liam morland do you have time to tag a beta release?

Sure, later today.

6.3.0-beta1 released.

Automatically closed - issue fixed for 2 weeks with no activity.