Error: Call to a member function getEntityTypeId() on null

#0 /web/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\commerce_api\Resource\CartAddResource->Drupal\commerce_api\Resource\{closure}() #1 /web/modules/contrib/commerce_api/src/Resource/CartAddResource.php(106): Drupal\Core\Render\Renderer->executeInRenderContext() #2 /web/modules/contrib/jsonapi_resources/src/Unstable/Controller/JsonapiResourceController.php(70): Drupal\commerce_api\Resource\CartAddResource->process() #3 [internal function]: Drupal\jsonapi_resources\Unstable\Controller\JsonapiResourceController->processRequest() #4 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array() #5 /web/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #6 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext() #7 /web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() #8 /vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #9 /vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw() #10 /web/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle() #11 /web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle() #12 /web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle() #13 /web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle() #14 /web/core/modules/page_cache/src/StackMiddleware/PageCache.php(116): Drupal\big_pipe\StackMiddleware\ContentLength->handle() #15 /web/core/modules/page_cache/src/StackMiddleware/PageCache.php(90): Drupal\page_cache\StackMiddleware\PageCache->pass() #16 /web/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle() #17 /web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle() #18 /web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() #19 /web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() #20 /web/modules/contrib/remove_http_headers/src/StackMiddleware/RemoveHttpHeadersMiddleware.php(49): Drupal\Core\StackMiddleware\AjaxPageState->handle() #21 /web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\remove_http_headers\StackMiddleware\RemoveHttpHeadersMiddleware->handle() #22 /web/core/lib/Drupal/Core/DrupalKernel.php(741): Drupal\Core\StackMiddleware\StackedHttpKernel->handle() #23 /web/index.php(19): Drupal\Core\DrupalKernel->handle() #24 {main}

Comments & Activities

Issue created by @Anybody
Comment 30 days ago →
🇩🇪Germany Anybody Porta Westfalica
#3495550: Call to a member function hasPurchasedEntity() on null → was another effect of this call.
First commit to issue fork.
Comment 6 days ago →
🇩🇪Germany Grevil
Wrong module.
Comment 6 days ago →
🇩🇪Germany Grevil
Comment 6 days ago →
🇩🇪Germany Grevil
grevil → changed the visibility of the branch 3495551-error-call-to to hidden.
Merge request !27Issue #3495551: Error: Call to a member function getEntityTypeId() on null → (Closed) created by Grevil
Comment 6 days ago →
🇩🇪Germany Grevil
Pipeline finished with Failed
6 days ago
Total: 349s
#396623
Comment 6 days ago →
🇩🇪Germany Grevil
Alright, this should be it for the time being. I am unsure whether this is the correct approach or if we should allow a quantity of "0" and simply add a NULL check in line 183.

I also thought about implementing the check in the "EntityValidationTrait" "validate()" method, but that class seems really general and not really meant for order item validation, so I dropped the thought again.
Merge request !28Issue #3495551: Error: Call to a member function getEntityTypeId() on null, when order item quantity is "0" → (Open) created by Grevil
Comment 6 days ago →
🇩🇪Germany Grevil
All done, @jsacksick should decide, which approach to use here!
Pipeline finished with Failed
6 days ago
Total: 259s
#396638
Comment 6 days ago →
🇩🇪Germany Anybody Porta Westfalica
Thank you very much @grevil! Nice finding and fix!

I'm a bit more in favour of MR!28 I have to say, looks cleaner to me. But let's see what @jacksacksick says!
Comment 6 days ago →
🇩🇪Germany Anybody Porta Westfalica
Failing tests look unrelated, let's open a separate issue for that.
Comment 6 days ago →
🇩🇪Germany Grevil
I will close the !MR 27, just had a look at 🐛 Price calculation fails with a fatal error on zero quantity order items that have adjustments Needs review . And there seems to be a use case for having a quantity of 0.
Comment 6 days ago →
System Message
grevil → closed merge request !27

Error: Call to a member function getEntityTypeId() on null

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!27Error: Call to a member function getEntityTypeId() on null
Closed

!28Error: Call to a member function getEntityTypeId() on null
Open

Comments & Activities

Error: Call to a member function getEntityTypeId() on null

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!27Error: Call to a member function getEntityTypeId() on null Closed

!28Error: Call to a member function getEntityTypeId() on null Open

Comments & Activities

!27Error: Call to a member function getEntityTypeId() on null
Closed

!28Error: Call to a member function getEntityTypeId() on null
Open