- Issue created by @s_leu
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .
- Merge request !10630Issue #3494997: Introduce workspace aware shared tempstore override → (Closed) created by s_leu
- 🇷🇴Romania amateescu
I don't think we should take the route of providing a generic workspace-aware temp store implementation, we have #3026957: Provide a generic TempStoreIdentifierInterface that any object can use to better identify itself → for that, so let's keep this issue focused on the specific problem we have: LB's temp store needs to be workspace-aware.
Let's decorate the
layout_builder.tempstore_repository
service with a class that extendsLayoutTempstoreRepository
, and overrides itsgetKey()
method to append the current workspace ID. Then test coverage needs to be added in\Drupal\Tests\workspaces\FunctionalJavascript\WorkspacesLayoutBuilderIntegrationTest
. - 🇬🇧United Kingdom catch
This is tricky but the solution makes sense. I wondered about whether we could add some kind of 'extra keys' container parameter that layout builder could respect, and workspaces could add to, a bit like required render cache contexts, but that feels like it should be its own issue if at all.
Committed/pushed to 11.x, thanks!
- Status changed to Fixed
about 2 months ago 1:24pm 25 February 2025 Automatically closed - issue fixed for 2 weeks with no activity.