- Issue created by @Liam Morland
- Merge request !8Issue #3494846: Enable GitLab CI automated testing → (Merged) created by Liam Morland
- 🇨🇦Canada smulvih2 Canada 🍁
Looks good @liam, let me know once you are ready to run the tests.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
It could be merged anytime. There are a few simple issues outstanding that should be fixed.
- 🇨🇦Canada smulvih2 Canada 🍁
Looks like cspell fails, might need to add these words ['Frontdoor', 'wildcardpath', 'azurecdn']. As well some issues with README.md, maybe this can be ignored completely from cspell.
PHPStan showing this:
------ ---------------------------------------------------------------------- Line src/Form/AzureCdnPurgeForm.php ------ ---------------------------------------------------------------------- 68 Method Drupal\Core\Form\ConfigFormBase::__construct() invoked with 1 parameter, 2 required. ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line src/Plugin/Purge/Purger/AzurePurger.php ------ ---------------------------------------------------------------------- 149 \Drupal calls should be avoided in classes, use dependency injection instead 174 \Drupal calls should be avoided in classes, use dependency injection instead ------ ----------------------------------------------------------------------
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
I'm referring to the line 68 issue.
Some of the spelling failures are spelling errors that should be fixed. Some can be ignored in
.gitlab-ci.yml
by setting_CSPELL_WORDS
. -
liam morland →
committed 84c512b2 on 1.0.x
Issue #3494846: Make spelling corrections and exceptions
-
liam morland →
committed 84c512b2 on 1.0.x
-
liam morland →
committed 29d6e498 on 1.0.x
Issue #3494846: Remove use of deprecated SPDX license identifier
-
liam morland →
committed 29d6e498 on 1.0.x
-
liam morland →
committed 14206aed on 1.0.x
Issue #3494846: Add .gitlab-ci.yml from template
-
liam morland →
committed 14206aed on 1.0.x
- 🇨🇦Canada smulvih2 Canada 🍁
This gets the GitLab tests working without errors, just warnings on some dependency injection. Will close this ticket and we can fix dependency injection issues in separate ticket.
Automatically closed - issue fixed for 2 weeks with no activity.