Contrib.social

Drupal 11.1 compatibility

Open on Drupal.org →
Created on 18 December 2024, about 1 month ago

Problem/Motivation

Drupal 11.1 has been released Sunday 15 December, and ui_icons is not currently compatible:

 [error]  TypeError: Drupal\Core\Theme\Icon\IconCollector::__construct(): Argument #1 ($iconPackExtractorManager) must be of type Drupal\Core\Theme\Icon\IconExtractorPluginManager, Drupal\ui_icons_backport\IconExtractorPluginManager given, called in /web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\Core\Theme\Icon\IconCollector->__construct() (line 26 of /web/core/lib/Drupal/Core/Theme/Icon/IconCollector.php) #0 /web/core/lib/Drupal/Component/DependencyInjection/Container.php(259): Drupal\Core\Theme\Icon\IconCollector->__construct()

Because the info file still has a dependency to ui_icons_backport:

name: 'UI Icons Form element'
type: module
description: 'Core Icons main form element for Icon autocomplete.'
package: User interface
core_version_requirement: ^10.3 || ^11.0
# @todo remove for 11.1
dependencies:
  - ui_icons:ui_icons_backport

Proposed resolution

What do we do?

A proposal from Florent would be to maintain 2 branches:

  • 1.0.x with ^10.3 || ^11.0 and the actual ui_icons_backport sub-module
  • 1.1.x with ^11.1 and an empty ui_icons_backport sub-moidule

I am not comfortable about introducing a second branch that early, but I don't have any better solution yet.

Any other ideas?

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024