Fix automated tests

Once again, thanks a lot for your help on this issue @ressa!

Bumping to Major as this is breaking tests for a lot of merge requests in pending tickets.

Tests are passing with warnings:
https://git.drupalcode.org/issue/admin_toolbar-3494654/-/pipelines/392909

Thanks in advance for your reviews and feedback!

The PHPCS pipeline is now passing and is now green
I guess this issue can now be merged as it would at least solve the breaking tests for a lot of merge requests in pending tickets.

Thanks @dydave, I am really grateful for your efforts with keeping Admin Toolbar in good shape!

I agree that this issue should be elevated to major. Really, any time the basic tests are failing in a project, the issue created should be major, since it makes the process of all other issues break down ...

@akulsaxena: Feel free to change the Status to RTBC, so we can keep this issue moving.

Moved to RTBC+

The tests are still broken ... please, can we get this MR committed? It has been RTBC for a month now. Tests have been failing at least since 17 Dec 2024 ...

This is blocking all other issues from getting fixed, since users think their MR's are failing. Thanks!

(Adding a related issue as an example of an issue with a one line change, which should not have a failing test.)

PS. @DYdave: Maybe apply to become co-maintainer, since you already maintain other modules, and quite active within this module?

Thanks a lot @ressa once again for your follow-up on this issue and in the module in general!

I'd be really honored to be able to become one of the maintainers of the admin_toolbar module and would be very happy to help.

tests have been failing for three months now, since 13 Nov 2024

I definitely agree a module as popular as admin_toolbar should probably be more closely monitored and maintained.
It would be good to see more regular/continuous code changes made to the dev branch, instead of spikes of activity with batches of merge requests being processed just before creating a new release.

I have sent a private message directly to one of the maintainers that I had the chance to meet at DC Barcelona last September (2024) and to Romain (@romainj), as suggested by Adrian at #3463441-9: Offering to co-maintain Admin Toolbar → to offer helping as a maintainer or request assistance with this issue.

Hopefully, I should be able to get a reply, otherwise, I'll be glad to create a standard issue to formally offer to become a maintainer.

Otherwise, once again, we would greatly appreciate if a maintainer with write access could take a look at merge request MR!107 and let us know if any more changes would be needed.

Feel free to let us know if you have any questions, comments or concerns on any of the changes suggested in this ticket, we would surely be glad to help.
Thanks in advance!

You're welcome @DYdave! I hope you get an answer from the maintainers. Like you write, it would be nice to get a more steady stream of RTBC issues committed and released, and not as currently, in ketchup effect-like release spurts.

You could even consider creating an issue straight away, since that looks like it's step #1 for formally applying → ? It's just in case there is no reply, and eventually the issue will be moved (Step #6 "If maintainers do not reply in two weeks since the offer appeared ...").

That's it @ressa!! It worked!

Romain replied positively, really quickly and added me as maintainer of the module \o/

I now have write access ! We're in business!
Let's get cracking!

Let's get these changes merged and all other MRs/tickets unblocked! 👍

Thanks everyone and @ressa in particular for the great help on this issue!

Ticket's merge request was merged above at #16.

The tests are now passing with warnings:
https://git.drupalcode.org/project/admin_toolbar/-/pipelines/426635
(to be fixed in other tickets)

But at least all other pending issues and MRs should now be unblocked and we should be able to keep moving forward with the next requested changes.

Thanks again everyone!

This is awesome and fantastic news, congratulations @dydave! And thank you very much @romainj for a fast response. I just rebased 🐛 Compatibility issue: Route update.theme_install does not exist in Drupal 11.0.x Active and the test is now green, after the dev-tests got fixed. It will be so great to get some traction, and faster rollout speed of this module, so looking forward to that :)

Automatically closed - issue fixed for 2 weeks with no activity.