[PP-1] Handle media image fields on page data form

Created on 17 December 2024, 6 months ago

Overview

Save page data form values in application state with support for undo/redo Active didn't address media fields: the selected image is not stored in the application state. Selection is currently possible for newly added images. The form control to remove the selection is also missing.

Proposed resolution

See if we need to adjust or replicate experience_builder_field_widget_single_element_media_library_widget_form_alter() and/or experience_builder_preprocess_media_library_item__widget() for the page data form.

📌 Task
Status

Postponed

Version

0.0

Component

Redux-integrated field widgets

Created by

🇳🇱Netherlands balintbrews Amsterdam, NL

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @balintbrews
  • 🇳🇱Netherlands balintbrews Amsterdam, NL
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Feel free to ping me when you dig into this; @bnjmnm is the real expert in that area, but happy to assist when @bnjmnm has more important things to tackle!

  • Status changed to Active 17 days ago
  • 🇫🇮Finland lauriii Finland
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    No longer relevant as this was addressed by other work. There is confirmation of this in the test 'Can open the media library widget in an xb_page props form' in media-library.cy.js (this test does more than just open, it adds / removes etc.)

  • 🇫🇮Finland lauriii Finland

    Maybe there's something more specific that's wrong but this doesn't seem to be working for me? Attached video to show what I'm seeing.

  • 🇫🇮Finland lauriii Finland
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    Clearly a problem is occurring in #7 but it isn't one I'm running into (see this video) + this and the e2e test mentioned in #5 demonstrate that "Handl[ing] media image fields on page data form" currently works.

    The error in #6 looks like it's coming from OpenAPI validation, which should obviously be addressed. If anyone currently experiencing it can either update this issue summary or create a new issue targeting that specific bug

  • 🇺🇸United States bnjmnm Ann Arbor, MI
Production build 0.71.5 2024