- Issue created by @Anybody
- 🇩🇪Germany Anybody Porta Westfalica
Let's also fix code style, where automation is able to.
- First commit to issue fork.
- 🇩🇪Germany Grevil
The test failures are related to the external cookiesjsr svelte library (see my comment here: https://www.drupal.org/project/cookies/issues/3496407#comment-15941167 📌 Review markup / CSS before 2.0.0 Active ).
Let's postpone this issue on 📌 Review markup / CSS before 2.0.0 Active right now. Afterward, we can see what the status of the tests is.
- 🇩🇪Germany Grevil
Alright! From the discussion in 📌 Review markup / CSS before 2.0.0 Active , we don't need the extra span anymore, so this can go active again!
- 🇩🇪Germany Grevil
Ok, nevermind actually. There are too many markup changes inside https://github.com/jfeltkamp/cookiesjsr/pull/42/files, so we would need to readjust the tests AGAIN, after that issue is merged.
Postponing again. This time on https://github.com/jfeltkamp/cookiesjsr/pull/42/files
Note, we should add an update hook, letting the user know about the BC concerning the adjusted HTML (if anyone adjusted the cookies banner).
- 🇩🇪Germany Anybody Porta Westfalica
https://www.drupal.org/project/cookies/issues/3496407 📌 Review markup / CSS before 2.0.0 Active is fixed now, could you fix the tests @grevil?