- Issue created by @dieterholvoet
- Merge request !20Add PdfGeneratorManagerInterface & getForNode method β (Open) created by dieterholvoet
- π¬π§United Kingdom scott_euser
Thanks! So this is 'Needs work' in that you want us to review & merge β¨ Add support for generating a separate PDF per domain Active first right? Or that you want to do more work on it first?
- π§πͺBelgium dieterholvoet Brussels
No, this needs more work. The different places instantiating plugins need to either pass the config themselves or use the new factory method. Then, the code in the plugin needs to be changed to use
$this->configuration
. All this only if you agree with my proposal here though. Itβs not super important, just adding the factory method without passing config to the plugin would also help with simplifying certain code. - π¬π§United Kingdom scott_euser
Yeah that sounds fine. At least for our sites we don't have custom plugins, so no BC for us. I can add it to next release notes in any case for the few other sites that are using the module that are not from us. Thanks!