- Issue created by @dieterholvoet
- 🇧🇪Belgium dieterholvoet Brussels
@scott_euser what do you think? I'm probably going to start implementing this on Monday.
- 🇬🇧United Kingdom scott_euser
I think the proposed resolutions are 'OR' right? If so I think any of options 2-4 are fine. I guess 2 & 3 would be least work for you but if you think others could benefit from 4, sounds great too!
On option 1, I am worried it will remove features. E.g. some things we have some clients using:
- Translation of fields in/surrounding media, the UX let's them translate on the node page
- Access control in members area auto-applying to attachments via Entity Usage
- Ability for clients to e.g. maybe start with a quick page to PDF and use that for most, but then maybe more important annual report or something they decide to replace with an InDesign curated version
Thanks for your contributions in any case!
- 🇧🇪Belgium dieterholvoet Brussels
I created a branch from ✨ Add option to automatically generate PDFs after saving nodes in a queue Active because there's too much overlap, so the changes from that MR are also in this one. We should merge that one first and then rebase this one. The current implementation seems to work for my use case, but it still needs some more testing.
I also added the
page_to_pdf_domain
submodule that provides the integration with thedomain
/domain_access
modules. For now it only creates queue items, it doesn't work yet with the batch way of doing things. - 🇬🇧United Kingdom scott_euser
Thanks! So this is 'Needs work' in that you want us to review & merge the issue mentioned in #5 first?
- 🇧🇪Belgium dieterholvoet Brussels
Yes, but this one also needs a little more testing IMO. Not working today, but I’ll try to do that tomorrow or Friday.
- 🇬🇧United Kingdom scott_euser
Just had a quick look at the WIP and it seems its going down the key value store direction; ie, the option 1 from the issue summary (converted IS to ol from ul now to be clear) which I raised concerns about in #4. If you feel you really need a different storage than Media/File fields maybe its better to have load/save in a service so you can replace the service in your own way for your projects?