- Issue created by @plopesc
- Merge request !10569Issue #3494194: Menu Edit form is not saving properly overridden values properly → (Closed) created by plopesc
- 🇪🇸Spain plopesc Valladolid
Created MR.
Tested manually and there are no regressions.
Bug was not caught by tests because
MenuLinkDefaultFormTestis a Unit test. To catch this we need a functional test where Claro is the default admin theme.However, functional tests in claro are quite limited.
Should we add a Functional test in Claro for this bug? Or should we rely only in manual testing?
- 🇪🇸Spain plopesc Valladolid
Added test coverage in Claro theme.
Test checks that form elements have been added to the new container and the submitted values are saved as expected.
- 🇺🇸United States smustgrave
Verified the issue following the steps.
1. Went to /admin/structure/menu/link/standard.front_page/edit?destination=/admin/structure/menu/manage/main
2. Changed weight to 10 snd checked expanded
3. Nothing saved.Applied the MR
Same steps and they now save.
- 🇳🇿New Zealand quietone
I read the IS, comments and the MR. I didn't find any unanswered questions or other work to do.
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.5.x, thanks!
- Status changed to Fixed
about 2 months ago 7:42pm 17 February 2025 Automatically closed - issue fixed for 2 weeks with no activity.