- Issue created by @pameeela
- πΊπΈUnited States phenaproxima Massachusetts
So on the one hand, Project Browser now has the ability to expose a particular source (recipes, in this case) at a dedicated page. I believe that's in the most recent tagged release, but don't quote me on that.
On the other hand, it doesn't expose menu links to those pages. The fact that the designs call for a local task (tab) complicates things, because as far as I know, you cannot ship a local task as a content entity.
That leaves two possible approaches I can think of:
- Can we define local tasks using the
core.static_menu_link_overrides
config object? If so, that's definitely preferable. - If we can't do that, then is there, by any chance, a contrib module -- Drupal 11 compatible, ideally with beta (or better) stability and security coverage -- that lets you define local tasks as configuration or content entities? If such a module exists, we could leverage it for this purpose.
- Can we define local tasks using the
- First commit to issue fork.
- Merge request !310Issue #3493719: Create standalone recipes page for local recipes β (Merged) created by jurgenhaas
- πΊπΈUnited States phenaproxima Massachusetts
Well that is damn nice. I'll write a test and sync it up with HEAD.
- πΊπΈUnited States phenaproxima Massachusetts
Added test coverage, which is failing because the Recipes tab doesn't get the
is-active
class. Any insight into that, @jurgenhaas? - πΊπΈUnited States phenaproxima Massachusetts
Happy with this. Assigning to @pameeela for final review.
- π¦πΊAustralia pameeela
Suuuuuper excited to see this working! I made two minor changes to align with the designs: Updated the menu link to be 'Recommended' (we want to avoid using 'Recipes' in this context since it's pretty meaningless to Drupal newbies) and moved it to be first.
Still some work to do but marking RTBC because I think this is great as an incremental improvement.
- πΊπΈUnited States phenaproxima Massachusetts
Tests are failing; I think you need to change the assertion of a "Recipes" link to "Recommended".
-
phenaproxima β
committed 9339f1d7 on 1.x authored by
jurgenhaas β
Issue #3493719 by pameeela, phenaproxima, jurgenhaas: Create standalone...
-
phenaproxima β
committed 9339f1d7 on 1.x authored by
jurgenhaas β
- πΊπΈUnited States phenaproxima Massachusetts
I agree - a good improvement by itself, and certainly worth iterating on more. Merged into 1.x. Thanks!
-
phenaproxima β
committed 3cdf75ce on 1.0.x authored by
jurgenhaas β
Issue #3493719 by pameeela, phenaproxima, jurgenhaas: Create standalone...
-
phenaproxima β
committed 3cdf75ce on 1.0.x authored by
jurgenhaas β
- πΈπ°Slovakia poker10
I think there are two issues here (not sure if I should create a new issue for this, so commenting for now):
1. The proposed solution was to set this as a default page when user click on "Extend". This seems not done
2. When you open the "Recommended" tab, you have "is-active" class on both "Recommended" and "Browse" tabs, which is not idealThanks!
- π¦πΊAustralia pameeela
Yes, these are known issues to handle in follow ups, just have not gotten around to creating them!
- πΈπ°Slovakia poker10
I have created one follow-up, which seems more serious than the is-active class: π Cannot access Project Browser UI for contrib modules listing when on Recommended tab Active
Automatically closed - issue fixed for 2 weeks with no activity.