- Issue created by @dieterholvoet
- Merge request !33Replace the $entity_type argument with $entity_type_id → (Merged) created by dieterholvoet
- 🇷🇴Romania amateescu
To prevent the BC break and the need for a new major branch, we could allow
EntityTypeInterface|string
for the $entity_type_id parameter and, if the argument is an instance of EntityTypeInterface, get the entity type ID from it :) - 🇧🇪Belgium dieterholvoet Brussels
Are you sure a method parameter type change is not a BC break? It wouldn't be for callers, but it would be for implementers. Not sure how big of a problem that would be in practice though, probably not (m)any other implementations out there.
- 🇷🇴Romania amateescu
If we really want to be sure, we can completely remove the type from the argument and replace it with an assertion on the first line of the method. And yeah, I'm also pretty sure there aren't many trash manager decorators in the wild.
- 🇧🇪Belgium dieterholvoet Brussels
I went for the union type, up to you if you want to remove the type.
-
amateescu →
committed 5ea435d4 on 3.x authored by
dieterholvoet →
Issue #3493493: Infinite loop when trash and eck_bundle_permissions...
-
amateescu →
committed 5ea435d4 on 3.x authored by
dieterholvoet →
- 🇷🇴Romania amateescu
That's fine, we can always remove the type if anyone reports it as problematic.
Merged into 3.x, thanks!