Missing hidden depedency on edit_plus

Created on 10 December 2024, 12 days ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

heddn Nicaragua

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @heddn
  • Merge request !7Update toolbar_plus.info.yml β†’ (Open) created by heddn
  • πŸ‡ΊπŸ‡ΈUnited States tim bozeman

    Thank you Lucas! There's actually a bunch of technical debt around this one. Not totally sure what to do about in the meantime tbh.

    Edit+ is a tool plugin for Toolbar+. So I think the info files are correct in that edit+ depends on toolbar+, but yeah there is definitely a hidden dependency. Would the two modules depending on each other cause a circular dependency? I've ran into that before, but not sure how I got there.

    Edit+ and Layout Builder share a tempstore for hanging onto changes before the entity is saved. Because of the order that the modules were developed the tempstore handling is in Edit+ at the moment, but it should really be bubbled up to toolbar+.

  • πŸ‡ΊπŸ‡ΈUnited States tim bozeman

    There are still some sea change tasks coming up where this will be addressed.

  • πŸ‡ΊπŸ‡ΈUnited States tim bozeman

    Also, this module is probably going to be moved to navigation_plus since we started using navigation when it came out.

Production build 0.71.5 2024