Split up EntityDefinitionUpdateTest

First pass - five of the test methods don't need the extra entity_test_update installed in __construct(), so that's an easy start.

160s on https://git.drupalcode.org/project/drupal/-/jobs/3651470

Block Cache (Drupal\Tests\block\Functional\BlockCache)
     ✔ Cache per role
     ✔ Cache permissions
     ✘ No cache

Seems to be un-related

Needs a reroll. I did not review the changes

This wasn't really rebasable because too much had changed in moved code, so redid the same changes from scratch.

Having done this all over again, still feel about the same as #4 - we could split it into bundle/base fields to have a more even split, but that wouldn't reduce the overall work, whereas this does slightly reduce the actual work done in the test.

https://git.drupalcode.org/issue/drupal-3492944/-/jobs/5115788 this job has both tests and they're very far under the longest tests now, so the split is enough to solve the problem.

Going purely on the move, didn't look at the actual tests for typehints or any of that as I understand the scope to be just that a move.

Not super awesome to add so much to the baseline but probably not a blocker.

The extra baseline comes from the trait, I don't know a way around that.

There are 282 test methods in grep -R "public function test" core/tests/Drupal/KernelTests/Core/Entity | wc -l before and after applying the patch and the lest change was 4 weeks ago which is before #7 so I think we are good here.

The only way to fix the baseline stuff is to add return typehints to all the test traits - which would be a great thing to do imo.

Committed and pushed 6d6f909d46e to 11.x and 699effc461f to 11.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.