- Issue created by @zniki.ru
- First commit to issue fork.
Use proper assertion.
E.g. assertStringContainsString(), assertStringNotContainsString(),...
Follow-up for
🐛
Crop API is not appending a hash when the image styles are converted to WEBP
Needs review
.
Command
grep -nri '\->assert.*strpos' crop
Result
grep -nri '\->assert.*strpos' crop
crop/tests/src/Functional/CropFunctionalTest.php:193: $this->assertTrue(strpos($image_style_uri_url, $shortened_hash) !== FALSE, 'The image style URL contains a shortened hash.');
crop/tests/src/Functional/CropFunctionalTest.php:196: $this->assertTrue(strpos($image_style_url, $shortened_hash) !== FALSE, 'The image style URL contains a shortened hash.');
crop/tests/src/Functional/CropFunctionalTest.php:204: $this->assertFalse(strpos($image_style_url, $old_hash) !== FALSE, 'The image style URL does not contain the old hash.');
crop/tests/src/Functional/CropFunctionalTest.php:205: $this->assertTrue(strpos($image_style_url, $new_hash) !== FALSE, 'The image style URL contains an updated hash.');