- Issue created by @guido_s
- πΊπ¦Ukraine nginex
Hello,
There is a notes in the release https://www.drupal.org/project/single_content_sync/releases/1.4.7 β
Did you try that already?
I noticed it on one project too, but not for others, seems like a cache issue. Reinstall module to fix it
- π©πͺGermany guido_s Cologne
Reverting to 1.4.6 and then updating to 1.4.7 again seems to work, but it would be good if it was working on the first attempt as I'm concerned what would happen on automatic deployments on several stages as this will just install what's in composer.json and core.extension.yml and not uninstalling and reinstalling anything. Would be bad if this is some kind of gambling on which environments it will work and on which it will break anything.
So this could still be an issue. - πΊπ¦Ukraine nginex
@guido_s
in terms of code it's looking good, there are no breaking changes or so, just one more service is added to dependency injection, so nothing I can do there. I already deployed the upgrade for multiple projects and there were no issues, so I need more details about environment where it happened or at least what drupal core version was used to understand and apply a possible fix.
- πͺπΈSpain rodrigoaguilera Barcelona
Usually modules changing injected services add an empty hook_post_update_NAME() to force a cache clear. Read more here:
https://www.drupal.org/node/2960601 βTo solve a single_content_sync.post_update.php file can be created with this hook.
- πΊπ¦Ukraine nginex
@rodrigoaguilera it might work, thanks, will need to create a new release to include that file, I will review other issues as well, so I can include multiple fixes to a new release
- Merge request !130Issue #3492601: Updating to 1.4.7 breaks site β (Merged) created by rodrigoaguilera
- πͺπΈSpain rodrigoaguilera Barcelona
I tested on the site that was giving me problems to update
-
rodrigoaguilera β
committed ba918f83 on 1.4.x
Issue #3492601: Updating to 1.4.7 breaks site
-
rodrigoaguilera β
committed ba918f83 on 1.4.x
- πΊπ¦Ukraine nginex