Default font sizes need class attribute allowed on span tag

Open on Drupal.org →

Created on 5 December 2024, about 2 months ago

Problem/Motivation

If default font sizes are used, they are implemented as classes on span tag. Plugin definition only allows `` which then results in stripping of classes by "Allowed HTML tags" filter.

Steps to reproduce

Enabled font size plugin
It will add <span> to "Allowed HTML tags" filter.
Use font size on the content with options of tiny and large.
See that in CKEditor it works.
Save the content, check it in frontend.
Observe the span tags without classes and no difference in font size.

Proposed resolution

Add <span class> to elements of ckeditor5_plugin_pack_font__font_size plugin

🐛 Bug report

Status

Active

Version

1.2

Component

Code

Created by

🇩🇪Germany a.dmitriiev

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!18Default font sizes need class attribute allowed on span tag
Merged
🇩🇪Germany a.dmitriiev
updated about 2 months ago

Comments & Activities

Issue created by @a.dmitriiev
Merge request !18Issue #3491958: Update file ckeditor5_plugin_pack_font.ckeditor5.yml → (Merged) created by a.dmitriiev
Comment about 2 months ago →
🇩🇪Germany a.dmitriiev
Comment about 2 months ago →
🇵🇱Poland salmonek
Hi @admitriiev
Tested, patch solves the issue. Thak you for the contribution.
Comment about 2 months ago →
System Message

salmonek → committed 1b78d6c8 on 1.2.x authored by a.dmitriiev →
Issue #3491958: Update file ckeditor5_plugin_pack_font.ckeditor5.yml
Comment about 1 month ago →
🇵🇱Poland salmonek
Patch has been merged and released in v 1.2.4
Comment 28 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024