- Issue created by @NikolaAt
- First commit to issue fork.
- Merge request !10473Issue #3491543: Catch and re-throw BadRequestException in Router::match() β (Closed) created by mfb
- πΊπΈUnited States mfb San Francisco
@nikolaat do you by chance have steps to reproduce this issue? If so you can fill in the steps to reproduce section of the issue summary.
- πΊπΈUnited States mfb San Francisco
Realized there is another Request::create() call in AccessAwareRouter, which I also patched
- πΊπΈUnited States smustgrave
Thanks for adding steps.
I followed the steps and can confirm I got Invalid URI: A URI must not start nor end with ASCII control characters or spaces.
Applied the MR and now I receive a 404 which definitely seems correct.1) Drupal\Tests\Core\Routing\RouterTest::testMatchesWithDifferentFitOrder Failed asserting that exception of type "Symfony\Component\HttpFoundation\Exception\BadRequestException" matches expected exception "Symfony\Component\Routing\Exception\ResourceNotFoundException". Message was: "Invalid URI: A URI must not start nor end with ASCII control characters or spaces." at /builds/issue/drupal-3491543/vendor/symfony/http-foundation/Request.php:315 /builds/issue/drupal-3491543/core/lib/Drupal/Core/Routing/Router.php:101 /builds/issue/drupal-3491543/core/tests/Drupal/Tests/Core/Routing/RouterTest.php:65 . FAILURES! Tests: 1, Assertions: 3, Failures: 1. Exiting with EXIT_CODE=1
Test coverage shows it too.
Believe this one is good to go.
Thanks for the quick update.
-
larowlan β
committed bd343240 on 10.4.x
Issue #3491543 by mfb: symfony/http-foundation Follow up issue for...
-
larowlan β
committed bd343240 on 10.4.x
-
larowlan β
committed 1fa732c9 on 10.5.x
Issue #3491543 by mfb: symfony/http-foundation Follow up issue for...
-
larowlan β
committed 1fa732c9 on 10.5.x
-
larowlan β
committed 1e356a6d on 11.1.x
Issue #3491543 by mfb: symfony/http-foundation Follow up issue for...
-
larowlan β
committed 1e356a6d on 11.1.x
-
larowlan β
committed c981ed1c on 11.x
Issue #3491543 by mfb: symfony/http-foundation Follow up issue for...
-
larowlan β
committed c981ed1c on 11.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 11.x and backported to 10.4.x, 10.5.x and 11.1.x
10.3.x and 11.0.x are now security only, so no backport to there.
- πΊπΈUnited States mfb San Francisco
This is at least security adjacent, since it's needed to apply symfony security updates..