Enable privacy app when applying Event recipe

Created on 3 December 2024, 18 days ago

Problem/Motivation

Locations for events are configured to display a map which is pulled from an external source. That requires the user's consent before those external resources can be loaded. This has been implemented in ✨ Add service to block Leaflet Active and as soon as this got published, we need to make sure that the new Klaro app, which will be present but disabled, will be enabled by the event recipe.

Proposed resolution

The config action for that should look like this:

config:
  actions:
    klaro.klaro_app.leaflet:
      simpleConfigUpdate:
        status: true
πŸ“Œ Task
Status

Active

Component

Track: Event

Created by

πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jurgenhaas
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Postponing on ✨ Add service to block Leaflet Active , but feel free to submit a merge request anyway.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    I looked at the related issue and have a concern. This is from the issue summary:

    Because tiles are external content, leaflet should only loaded after consent.

    Am I inferring correctly that, unless a user consents, the tiles won't load at all and the map will be broken? If so, we should probably think about whether we want to use this, because that would be a terrible user experience and would probably come off as broken behavior to a site owner.

    Let me know if I'm misunderstanding this.

  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    This is correct, but it won't look broken. Instead, it explains that a map will be loaded if there user accepts that their personal data will be transferred to an external service. This consent is managed inline and of the user clicks yes, the map will load dynamically.

    This is similar his this already works with remote videos.

    This is leading edge implementation on how privacy is supposed to be working on the web in general. Drupal will be leading the pack once again. πŸ˜€

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Well that sure sounds nice! I look forward to seeing it in action.

  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    New release tags for Klaro and for Leaflet are available, so this issue is no longer blocked.

  • First commit to issue fork.
  • Merge request !270Enable leaflet privacy β†’ (Merged) created by mandclu
  • Pipeline finished with Canceled
    18 days ago
    Total: 266s
    #359143
  • Pipeline finished with Failed
    18 days ago
    Total: 94s
    #359148
  • Pipeline finished with Failed
    18 days ago
    Total: 102s
    #359149
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Pipeline finished with Success
    18 days ago
    Total: 663s
    #359249
  • Pipeline finished with Success
    18 days ago
    Total: 667s
    #359250
  • Pipeline finished with Failed
    17 days ago
    Total: 539s
    #359290
  • Pipeline finished with Failed
    17 days ago
    Total: 731s
    #359319
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    I've reviewed the failing e2e test and it comes from autosave_form when trying to add a basic page as a content editor. Tried to reproduce this locally, but I can't. Is this a temporary failure in the pipeline, maybe?

  • Pipeline finished with Success
    17 days ago
    Total: 3057s
    #359320
  • Pipeline finished with Skipped
    17 days ago
    #359365
  • Pipeline finished with Skipped
    17 days ago
    #359367
  • Pipeline finished with Skipped
    17 days ago
    #359369
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    @jurgenhaas It's a goddamn random failure that keeps plaguing us, and I have been too busy to spend the time to stabilize it. That has to happen, but it can happen in the RC period or even post-stable.

    Merged into 0.x. Thanks!

  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Looking more closely, this is most likely an ajax error that cypress sees in the browser console. So, the request to /node/add/page is fine, but there subsequent Ajax request by auto save is causing that 500 error. Most likely a timing issue, therefore random. Hope that helps later when we get to this.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024