- Issue created by @jurgenhaas
- πΊπΈUnited States phenaproxima Massachusetts
Postponing on β¨ Add service to block Leaflet Active , but feel free to submit a merge request anyway.
- πΊπΈUnited States phenaproxima Massachusetts
I looked at the related issue and have a concern. This is from the issue summary:
Because tiles are external content, leaflet should only loaded after consent.
Am I inferring correctly that, unless a user consents, the tiles won't load at all and the map will be broken? If so, we should probably think about whether we want to use this, because that would be a terrible user experience and would probably come off as broken behavior to a site owner.
Let me know if I'm misunderstanding this.
- π©πͺGermany jurgenhaas Gottmadingen
This is correct, but it won't look broken. Instead, it explains that a map will be loaded if there user accepts that their personal data will be transferred to an external service. This consent is managed inline and of the user clicks yes, the map will load dynamically.
This is similar his this already works with remote videos.
This is leading edge implementation on how privacy is supposed to be working on the web in general. Drupal will be leading the pack once again. π
- πΊπΈUnited States phenaproxima Massachusetts
Well that sure sounds nice! I look forward to seeing it in action.
- π©πͺGermany jurgenhaas Gottmadingen
New release tags for Klaro and for Leaflet are available, so this issue is no longer blocked.
- First commit to issue fork.
- π©πͺGermany jurgenhaas Gottmadingen
I've reviewed the failing e2e test and it comes from
autosave_form
when trying to add a basic page as a content editor. Tried to reproduce this locally, but I can't. Is this a temporary failure in the pipeline, maybe? -
phenaproxima β
committed 38e7dde3 on 0.x authored by
mandclu β
Issue #3491406 by mandclu, phenaproxima, jurgenhaas: Enable privacy app...
-
phenaproxima β
committed 38e7dde3 on 0.x authored by
mandclu β
- πΊπΈUnited States phenaproxima Massachusetts
@jurgenhaas It's a goddamn random failure that keeps plaguing us, and I have been too busy to spend the time to stabilize it. That has to happen, but it can happen in the RC period or even post-stable.
Merged into 0.x. Thanks!
- π©πͺGermany jurgenhaas Gottmadingen
Looking more closely, this is most likely an ajax error that cypress sees in the browser console. So, the request to /node/add/page is fine, but there subsequent Ajax request by auto save is causing that 500 error. Most likely a timing issue, therefore random. Hope that helps later when we get to this.
Automatically closed - issue fixed for 2 weeks with no activity.