- Issue created by @jan kellermann
- 🇩🇪Germany jan kellermann
To modify the markup we need a change in the theme if leaflet. See #3491298
- 🇩🇪Germany jan kellermann
I added the code and a Klaro! service for Leaflet.
Leaflet issue #3491298 ✨ Add Attributes to template Active must be implemented before the change works.
Leaflet supports many maps provider, so I have kept the text neutral.
Please review.
- 🇩🇪Germany jurgenhaas Gottmadingen
This works like a charm :-) Thank you so much for the real quick turn-around. I'll ping some people to hopefully get the leaflet issue committed soon.
- 🇩🇪Germany jurgenhaas Gottmadingen
Just wondering, this service should probably be disabled by default and only enabled, when leaflets are actually in use. Otherwise users see this service in the consent management without reason.
- 🇮🇹Italy itamair
hi @folks ... thanks a lot,
this related Leaflet issue: https://www.drupal.org/project/leaflet/issues/3491298 ✨ Add Attributes to template Active
has been fixed and is already part of a brand new Leaflet 10.2.28 release.
Thus, green flag for Klaro support to Leaflet maps! - 🇩🇪Germany jan kellermann
@itamair Thank you very much! Thats amazing - and amazing quick!
@jurgenhaas Please decide if we should enable or disable this service by default - Please decide whether we activate the server by default or not - you know the goals of Drupal CMS best. Then I will merge and tag a new version.
- 🇩🇪Germany jurgenhaas Gottmadingen
Please decide if we should enable or disable this service by default - Please decide whether we activate the server by default or not - you know the goals of Drupal CMS best. Then I will merge and tag a new version.
I'd say, not just for Drupal CMS but also for Klaro on its own, that the consent management widget should only expose relevant services to the user. So, the question should be for vanilla Drupal sites, whether that will come with leaflet installed or not. And then, then default config should follow that assumption. I guess, leaflet is not present on most sites, and therefore I'd set the default to disabled. But I might be wrong.
Regardless, for Drupal CMS we know that leaflet is not enabled by default, and would override that config in the recipe to disable the leaflet service. It will then be enabled by the event recipe, which will also enable the leaflet module.
That way, we're flexible and can deliver the best default settings for both contexts.
-
jan kellermann →
committed 7ad46cc2 on 3.x
#3491325: Add service to handle Leaflet.
-
jan kellermann →
committed 7ad46cc2 on 3.x