- Issue created by @tgoeg
I have removed the space before and created the patch please review it .
- Status changed to Needs review
3 months ago 1:05am 6 May 2025 - π³πΏNew Zealand luke.stewart
luke.stewart β made their first commit to this issueβs fork.
- π³πΏNew Zealand luke.stewart
That patch seems to be wrong. I've created an Issue fork done the rename and pushed.
Hopefully this is easier to review.
> but I guess the post update step won't run like this.
If it does I think this is a problem!
- π¦πΉAustria tgoeg
Looks good to me, thanks.
However, I don't know how this script gets called and whether there need to be any further changes in some script(s) calling it.
Automatically closed - issue fixed for 2 weeks with no activity.
- π©π°Denmark ressa Copenhagen
@hatuhay: It looks like you forgot to credit the users, who supplied solutions to this great project, in the last few issues that I checked ... Maybe it has been like this for a while?
I think we need to acknowledge the work and effort of these issues, by giving them credit. (Check the boxes at the bottom, under "Hide Credit & committing").
- π΅πͺPeru hatuhay Lima
I do not recall on this specific case, but this kind of typos or other very simple errors are fixed within my own revisions or come as side fixes on other patches.
- π©π°Denmark ressa Copenhagen
Yes, it does look like the user input for this issue was minimal, so it was probably not the best example. I just noticed that in the last few issues, no credit was given ...