Don't allow adding suggestions with workspace conflicts

Posted some feedback on the MR.

Thanks for the review! I addressed the feedback adding a conflict message with links to conflicting workspaces as well as a visual indicator that makes it clearer that the row has a conflict in comparison with rows of items not having conflicts.

One remaining item from manually testing. Otherwise, this is looking nice. Great work.

If I edit a menu link in a workspace i.e. the link text goes from Purpose & Impact => Purpose & Impact Changed, then later attempt to translate the menu item in the live workspace, there are no conflict warnings. I think we should warn about a conflict in this case because the translation might come back to live before the conflicting workspace is published.

@heddn Thanks for reviewing again. It seems I missed some code in my latest push before that comment. I pushed further changes for this now.

Some feedback on your latest comment above:

• I cannot see an item in live listed as a suggestion after doing a manual translation of corresponding menu link via translate op on the menu tree edit form
• I think generally speaking, items which already have a translation in the target language and target workspace shouldn’t be listed in the suggestions in the first place. Should I file a follow up for this?
• Could you please test latest changes in the MR and if it doesn’t work, please provide step by step test instructions to replicate the problem?

I made one more small edit, but this looks great now. LGTM.

Reviewed the MR post-merge and the only thing I would've done differently is to not get the full list of workspaces that might track an entity (that can only happen when sub-workspaces are used atm), and pass TRUE as the second argument to the getEntityTrackingWorkspaceIds() call, which means that only one workspace will be returned. It's no big deal though, so I don't think it deserves a followup.

Automatically closed - issue fixed for 2 weeks with no activity.