Problem/Motivation
I've been experimenting with this module to see if it's viable for a client site and I've run into an interesting bug.
I am using a plugin that inserts <div>
s with the class well
on them and when I use this within a column, it breaks the layout quite a bit.
On first insert everything works fine and renders just fine, but when you then go to edit the content the .well div is converted into a column.
I have uploaded some screenshots to illustrate the issue.
Steps to reproduce
1. Edit content and add a 2 column grid
2. Inset div content (in my case a div with the .well class)
3. Save content. When viewed, everything looks fine.
4. Edit content. There will now be 3 columns.
5. Save content again. 3 columns will be rendered.
Proposed resolution
I've narrowed down the issue to the upcast for bsGridCol. The issue is it treats _all_ divs it finds as columns, which isn't necessarily what we want.
Adding a class (.bs_grid_col) would resolve the issue since it would then only treat those as columns. This would involve updating the upcast, downcast, and editingDowncast to handle the new class.
The issue with this approach is all existing columns would immediately become ignored by CKEditor because it would not see those divs as columns (which obviously is a pretty big problem).