Hardcoded Entity Key in Test

Changes are made on 11.x first, then backported.

Seems to have a number of out of scope changes.

Lets help out.

The out of scope changes are because the branch was made from another base than the current target. When you make the branch make sure you branch off the right place. It is also possible to 'rebase onto' a new branch and fix the weird changes, but that kinda depends on a decent amount of git knowlegde. If the changes are pretty minimal, just make a new branch of 11.x and commit the same stuff again. You could then force-push the branch to the existing one and it should be a-ok.

Thanks for the advice. I don't often contribute to core. I'm working on some more test cases and running into other issues of this sort. I'll be creating other tickets for these as well. Thanks again and please let me know if that works.

Alwyas love beginning with tests to prove something. :) ill keep an eye out.

I think it's ready for review actually. My issue is with the test cases themselves. My issue is that I'd like to build on core test cases to match functionality built on core, but as it stands the core test cases make assumptions like hard-coding the key for the owner field among others. I'd like to not have to maintain an entirely separate test case just to fix this.

Is there more that needs to be done to move this forward?

Fair enough. Looking at the change, this seems like a good update to make sure we actually test the correct key.

Committed f75163a and pushed to 11.x, cherry-picked to 11.1.x

Thanks!

quietone → closed merge request !10414