- Issue created by @vishalydv
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
- If you have not done it yet, you should run
- 🇮🇳India vishal.kadam Mumbai
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml pie_chart/ FILE: pie_chart/pie_chart.info.yml ---------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ---------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ---------------------------------------------------------------------------- FILE: pie_chart/pie_chart.routing.yml ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 15 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: pie_chart/README.md ------------------------------------------------------------------------ FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------ 3 | WARNING | [ ] Line exceeds 80 characters; contains 335 characters 14 | WARNING | [ ] Line exceeds 80 characters; contains 177 characters 26 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 32 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------ FILE: pie_chart/pie_chart.module ---------------------------------------------------------------------------- FOUND 20 ERRORS AFFECTING 16 LINES ---------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 5 | ERROR | [x] Expected 1 blank line before function; 0 found 6 | ERROR | [x] Opening brace should be on the same line as the declaration 7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 14 | ERROR | [x] Opening brace should be on the same line as the declaration 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 17 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 18 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 19 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 19 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 22 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 23 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 24 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 26 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 27 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 28 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 28 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------- FILE: pie_chart/pie_chart.libraries.yml ----------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------- 11 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------- FILE: pie_chart/pie_chart.links.menu.yml ------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------ 9 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------ FILE: pie_chart/src/Plugin/Block/NodePieChartBlock.php ---------------------------------------------------------------------------- FOUND 18 ERRORS AND 2 WARNINGS AFFECTING 17 LINES ---------------------------------------------------------------------------- 6 | WARNING | [x] Unused use statement 8 | WARNING | [x] Unused use statement 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\node\Entity\NodeType. 19 | ERROR | [x] Opening brace should be on the same line as the declaration 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Expected 1 blank line before function; 0 found 24 | ERROR | [x] Opening brace should be on the same line as the declaration 25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 28 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 29 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 30 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 32 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 33 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 34 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 35 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Expected 1 blank line after function; 0 found ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------- FILE: pie_chart/src/Controller/NodePieChartController.php ---------------------------------------------------------------------------- FOUND 79 ERRORS AND 11 WARNINGS AFFECTING 74 LINES ---------------------------------------------------------------------------- 9 | WARNING | [x] Unused use statement 10 | WARNING | [x] Unused use statement 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\user\Entity\User. 11 | WARNING | [x] Unused use statement 12 | WARNING | [x] Unused use statement 12 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 17 | ERROR | [x] Opening brace should be on the same line as the declaration 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Expected 1 blank line before function; 0 found 22 | ERROR | [x] Opening brace should be on the same line as the declaration 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 23 | WARNING | [ ] NodeType::loadMultiple calls should be avoided in classes, use dependency injection instead 24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 27 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 28 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 29 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 30 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 31 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 31 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 32 | ERROR | [x] Object operator not indented correctly; expected 14 spaces but found 16 36 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 37 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 38 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 41 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 42 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 43 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 45 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 46 | ERROR | [x] Space found after square bracket; expected "["node_counts"" but found "[ | | "node_counts"" 48 | ERROR | [x] Space found before square bracket; expected ""node_counts"]" but found ""node_counts" | | ]" 49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 56 | ERROR | [x] Opening brace should be on the same line as the declaration 56 | ERROR | [x] Whitespace found at end of line 57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 57 | WARNING | [ ] NodeType::loadMultiple calls should be avoided in classes, use dependency injection instead 58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 63 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 64 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 65 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 66 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 66 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 67 | ERROR | [x] Object operator not indented correctly; expected 14 spaces but found 16 71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 72 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 74 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Opening brace should be on the same line as the declaration 82 | WARNING | [ ] Unused variable $user_field_definitions. 82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 82 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 88 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 88 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 89 | ERROR | [x] Object operator not indented correctly; expected 14 spaces but found 16 91 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 92 | ERROR | [x] Object operator not indented correctly; expected 14 spaces but found 16 92 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 95 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 96 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 97 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 100 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 101 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 102 | ERROR | [x] Array indentation error, expected 10 spaces but found 12 103 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 104 | ERROR | [x] Array indentation error, expected 14 spaces but found 16 105 | ERROR | [x] Array indentation error, expected 18 spaces but found 20 109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Expected 1 blank line after function; 0 found ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 83 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------- FILE: pie_chart/css/pie_chart.css ---------------------------------------------------------------------------- FOUND 13 ERRORS AFFECTING 6 LINES ---------------------------------------------------------------------------- 4 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 4 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found 5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 5 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 6 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 6 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 6 | ERROR | [x] Each style definition must be on a line by itself 6 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 6 | ERROR | [ ] Style definitions must end with a semicolon 7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 8 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 9 | ERROR | [x] Expected 1 newline at end of file; 0 found 9 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------- FILE: pie_chart/pie_chart.links.task.yml ------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------ 9 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------