No option to disable incoming webhook debugging?

Created on 29 November 2024, 5 months ago

Problem/Motivation

Seems each incoming webhook requests leads to a full log entry with many details of the webhook!

This should be opt-in "Log debug messsages" option or sth. like that!

Typ 	commerce_paypal
Datum 	Freitag, 29. November 2024 - 16:11
Benutzer 	Gast (nicht รผberprรผft)
Ort 	https://www.example.com/payment/notify/paypal_checkout
Referrer 	
Benachrichtigung 	Eingehende Webhook-Anfrage:

Array
(... lots of details)

Schweregrad 	Debuggen

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ› Bug report
Status

Active

Version

1.0

Component

PayPal Checkout

Created by

๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Anybody
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica

    @jacksacksick: Could you give me a direction how you'd like this to be implemented? Then we'll prepare the MR. Thanks!

  • ๐Ÿ‡ฎ๐Ÿ‡ฑIsrael jsacksick

    We simply need a setting, also not sure why this is reported as a bug?

    We can go with 'log_webhook_requests', which defaults to TRUE to stick with the current behavior.

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica

    We simply need a setting, also not sure why this is reported as a bug?

    Because the debugging fills up logs, which I'd rate as unexpected, but let's not waste precious time on that and simple fix it :)

    Thanks for your feedback, we'll prepare a setting accordingly!

  • First commit to issue fork.
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Grevil

    This should probably do the trick already.

  • Pipeline finished with Canceled
    8 days ago
    Total: 128s
    #479390
  • Pipeline finished with Success
    8 days ago
    Total: 151s
    #479395
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Grevil

    Default could also be FALSE, and we create an update hook to set it TRUE for existing installations. You decide.

  • Pipeline finished with Success
    8 days ago
    Total: 148s
    #479408
  • ๐Ÿ‡ฎ๐Ÿ‡ฑIsrael jsacksick

    Default could also be FALSE, and we create an update hook to set it TRUE for existing installations. You decide.

    The simpler the better, I was more in favor of "log_webhook_requests" but since we have "enable_credit_card_icons" already, maybe we keep your pattern for consistency.

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Grevil

    Alright, let's use "FALSE" as the default, I don't think anyone really relied on the log message anyway.

  • Pipeline finished with Success
    7 days ago
    Total: 151s
    #480234
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica

    Thanks @Grevil: I agree and I think that (breaking) change is okay here, because it's more a fix of expected functionality and I don't really think anyone should heavily rely on this request logging.

    If we want, we could add an empty update hook to just inform developers about the new setting.

  • ๐Ÿ‡ฎ๐Ÿ‡ฑIsrael jsacksick

    No sorry, we should keep TRUE as the default, it's easy to change for people that really don't want it.
    Making FALSE as the default means it's going to change the default behavior and the change can go unnoticed...

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Grevil

    Alright! Adjusted accordingly!

  • Pipeline finished with Success
    6 days ago
    Total: 135s
    #480961
  • Pipeline finished with Skipped
    6 days ago
    #480973
  • Pipeline finished with Skipped
    6 days ago
    #480974
  • ๐Ÿ‡ฎ๐Ÿ‡ฑIsrael jsacksick
Production build 0.71.5 2024