- Issue created by @Anybody
- ๐ฉ๐ชGermany Anybody Porta Westfalica
@jacksacksick: Could you give me a direction how you'd like this to be implemented? Then we'll prepare the MR. Thanks!
- ๐ฎ๐ฑIsrael jsacksick
We simply need a setting, also not sure why this is reported as a bug?
We can go with 'log_webhook_requests', which defaults to TRUE to stick with the current behavior.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
We simply need a setting, also not sure why this is reported as a bug?
Because the debugging fills up logs, which I'd rate as unexpected, but let's not waste precious time on that and simple fix it :)
Thanks for your feedback, we'll prepare a setting accordingly!
- First commit to issue fork.
- Merge request !43Issue #3490702: Allow toggling webhook requests logging โ (Merged) created by Grevil
- ๐ฉ๐ชGermany Grevil
Default could also be FALSE, and we create an update hook to set it TRUE for existing installations. You decide.
- ๐ฎ๐ฑIsrael jsacksick
Default could also be FALSE, and we create an update hook to set it TRUE for existing installations. You decide.
The simpler the better, I was more in favor of "log_webhook_requests" but since we have "enable_credit_card_icons" already, maybe we keep your pattern for consistency.
- ๐ฉ๐ชGermany Grevil
Alright, let's use "FALSE" as the default, I don't think anyone really relied on the log message anyway.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Thanks @Grevil: I agree and I think that (breaking) change is okay here, because it's more a fix of expected functionality and I don't really think anyone should heavily rely on this request logging.
If we want, we could add an empty update hook to just inform developers about the new setting.
- ๐ฎ๐ฑIsrael jsacksick
No sorry, we should keep TRUE as the default, it's easy to change for people that really don't want it.
Making FALSE as the default means it's going to change the default behavior and the change can go unnoticed... -
jsacksick โ
committed d5daff96 on 8.x-1.x authored by
grevil โ
Issue #3490702: Allow toggling webhook requests logging
-
jsacksick โ
committed d5daff96 on 8.x-1.x authored by
grevil โ