- Issue created by @joseph.olstad
- 🇨🇭Switzerland berdir Switzerland
Are you actually interested in maintaining or just about getting a D11 release? That's fair, but also not really necessary then.
The module hasn't been configured to work with Gitlab CI so tests currently don't run. For simplicity, I'm happy to do that in the same issue as Drupal 11 compatibility, as we'd otherwise need to disable D11 tests only to re-enable them again.
Once tests are green on D10 and D11 I can merge that.
- 🇨🇦Canada joseph.olstad
Hi Sascha, I'm mainly just interested in a D11 release!
There currently is no ci pipeline and no tests, the D11 merge request looks very simple.
- 🇨🇭Switzerland berdir Switzerland
There is a test and DrupalCI used to run, the only thing that's necessary is add a default .gitlab-ci.yml template with OPT_IN_TEST_PREVIOUS_MAJOR and OPT_IN_TEST_PREVIOUS_MINOR enabled, then tests will run and it can be merged.
- 🇨🇦Canada joseph.olstad
I believe maintainers have access to a button that will generate the .gitlab-ci.yml file.
- 🇨🇭Switzerland berdir Switzerland
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → , that is not restricted to maintainers, everyone can update the the merge request, it's just a text file.
- 🇨🇦Canada joseph.olstad
Hi Sascha, there really is a button only accessible to project maintainers.
There's a video here explaining:
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →Please grant me maintainer access and then I'll press the button and generate a new .gitlab-ci.yml and add it to the Drupal 11 merge request.
Thanks
- 🇨🇭Switzerland berdir Switzerland
It really doesn't, all it does is require write access to the given repository. That requires maintainer for the main repository, but anyone can add it to a merge request. And it's much easier to copy an example from another module with the desired configuration anyway.
- 🇨🇦Canada joseph.olstad
ah ok, nvm, I'll revisit this module in 3 to 4 months from now when we're closer to a D11 upgrade.