- Issue created by @alok_singh
- First commit to issue fork.
- Merge request !2Issue-3490367-footer-needs-to: Added styling for footer. → (Open) created by akulsaxena
- 🇮🇳India akulsaxena
Hi
I have added styling for footer in the theme
Please review this - 🇮🇳India akulsaxena
Attaching Screenshot for reference
Added Bg color, hower effects and other styling Hi @akulsaxena,
Thank you for your effort on the MR; I appreciate the work you’ve done so far! However, I have a couple of suggestions to make the implementation more modular and maintainable:1. Instead of writing the SCSS code for the footer in base.scss, it would be better to create a dedicated footer.scss file under the scss/components folder. This helps keep the styles more organized and modular.
2. Regarding the use of
#block-cascade-footer1
, I noticed that this ID is dynamic and will change if the menu name changes (as shown in the attached screenshot). It would be more robust to use a static class or a specific selector tied to the block type to avoid future issues.
3. It will be better if you follow this layout design for footer attached below
- 🇮🇳India akulsaxena
Hey @sandip-poddar
Thanks for reviewing the MR
I am a bit occupied right now, can someone work on this?
Thanks