Cannot upload new image in media library

FWIW this was definitely working during Drupalcon Barcelona in late September so our troubleshooting can be in the mindset of "what broke this" vs. "we need to build this". Typically we'd have had tests that would have caught this, but the challenges of getting this set up in JS e2e tests made it a lower priority. Perhaps a PHP FunctionalJavascript test should accompany this fix as those tests are already equipped to handle file uplaods.

This is due to a change introduced in 🐛 XBEndpointRenderer adds response headers that sometimes exceed common server limits Active , it'll be a quick fix + a little additional time to add tests that prevent this from regressing.

The MR has a fix and a FunctionalJavascript test that verifies it works. Using FunctionalJavascript instead of Cypress E2E allows us to directly test file uploads.

However, as someone not all that well versed in Gitlab CI, I'm having trouble getting the built UI app to be available when the FunctionalJavascript tests run. Anyone is welcome to jump in and address that, and if this sits for too long I'll hit up the Gitlab docs and take care of the rest.

Was supposed to mark as needs work.

Any chance of this getting another look before Atlanta?

Tried to test the fix but it no longer applies.

I'm going to close this for now because AFAIK we don't have steps to reproduce this because Drupal CMS is running into 🐛 "Add media" button doesn't always open the media library Active . Once we get the media library to open, if we're unable to upload images, we could consider re-opening this one.

Oh, thanks -- good idea since I keep referencing the wrong one!

I snuck this fix for this into 📌 Media Library dialog styling Active because otherwise the majority of reviews there would switch it back to NW despite being unrelated. I'm reopening because MR here includes a test, which was the only thing stopping this from landing 3 months ago. I'm not quite good enough at gitlab CI config to know how to get the compiled XB app available to Functional Javascript tests (which I used because unlike e2e they have a solid way to test file uploads)

Looking for some @wim.leers help on why the test isn't passing on CI

This test runs fine locally but not here, and I can see from the test artifacts the XB UI at least partially loads, which confirms the JS is present.

One thing I"m not sure of, though, is if the routing in the XB UI can handle sites running from sub-directories. The final test artifact is the page reporting "An unexpected error has occurred in a route." and the first thing that comes to mind is the router not being able to handle the additional /web/ in the local test site.