Contrib.social

Undefined variable $settings in toastify_page_attachments()

Open on Drupal.org →
Created on 26 November 2024, 4 months ago

Problem/Motivation

After updating to the latest version a warning appears as such:

Warning: Undefined variable $settings in toastify_page_attachments() (line 52 of modules/contrib/toastify/toastify.module).

Steps to reproduce

Install the module and clear site cache.
The warning should appears on any front facing page.

Proposed resolution

Fix toastify_page_attachments(). The variable `$settings` just appeared out of nowhere.

Current code:

/**
 * Implements hook_page_attachments().
 */
function toastify_page_attachments(array &$page) {
  if (!toastify_is_active()) {
    return;
  }

  $page['#attached']['drupalSettings']['toastify']['settings'] = $settings;
  $page['#attached']['library'][] = 'toastify/toastify';
  $page['#attached']['library'][] = 'toastify/toastify.messages';

  if (_toastify_is_gin_theme_active()) {
    $page['#attached']['library'][] = 'gin/gin_base';
    $page['#attached']['library'][] = 'toastify/gin';
  }
}

Remaining tasks

Add back the following in `toastify_page_attachments()`:

$settings = \Drupal::config('toastify.settings')->get();
🐛 Bug report
Status

Active

Version

1.1

Component

Code

Created by

🇵🇭Philippines johnrosswvsu

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024