Contrib.social

Dependency injection and access check

Open on Drupal.org →
Created on 25 November 2024, 3 months ago

Problem/Motivation

Some of the improvements in the Drupal 11 rewrite ( 📌 Automated Drupal 11 compatibility fixes for wordpress_migrate Needs review ) (nov 25 version) can be brought forward into the next tagged release alpha7 - they are not dependent on Drupal 11 but are compatible with Drupal 9.

Namely SourceSelectForm.php adding TypedDataManager (link) , the accesscheck in ReviewForm (link), entityfieldmanager on ImageSelectForm (link).

This would not bring in the more sophisticated new factory, interface, config, and changes to static vs object methods, which are included in the D11 patch. This will make it more manageable, and give us a little better next tagged release.

Everyone who worked on the other thread will be credited for this as well.

Proposed resolution

Generate MR with only these elements, then move ahead to tagged release

Remaining tasks

User interface changes

None.

API changes

Adds a now mandatory "access check false" to the entity checks.

Data model changes

None besides using dependency injection instead of \Drupal services.

📌 Task
Status

Active

Version

3.0

Component

Code

Created by

🇺🇸United States hongpong Philadelphia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024