Created on 25 November 2024, 24 days ago

Problem/Motivation

The module needs some code improvement.

Steps to reproduce

N/A

Proposed resolution

Code improvement

Remaining tasks

MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇨🇦Canada nikathone Ontario

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @nikathone
  • Merge request !10Code updates → (Merged) created by nikathone
  • Pipeline finished with Success
    24 days ago
    Total: 206s
    #349691
  • Pipeline finished with Success
    24 days ago
    Total: 132s
    #349712
  • Pipeline finished with Success
    24 days ago
    Total: 135s
    #349720
  • Pipeline finished with Success
    24 days ago
    Total: 138s
    #349736
  • Pipeline finished with Success
    24 days ago
    Total: 203s
    #349785
  • Pipeline finished with Success
    23 days ago
    Total: 139s
    #350686
  • Pipeline finished with Success
    23 days ago
    Total: 139s
    #350831
  • Pipeline finished with Success
    23 days ago
    Total: 220s
    #350957
  • Pipeline finished with Success
    23 days ago
    Total: 135s
    #351042
  • Pipeline finished with Success
    22 days ago
    Total: 138s
    #352159
  • First commit to issue fork.
  • 🇨🇦Canada nikathone Ontario

    Added related issues that will help with the code added here.

  • Pipeline finished with Success
    16 days ago
    Total: 134s
    #357745
  • 🇺🇸United States andileco
  • 🇮🇪Ireland marksmith

    After updating Charts to version 5.1.1., I also needed to update ChartsDrilldownPluginStyleChart.php of Charts Highcharts Drilldown (version 1.1.0), in line with this PHP error message:

    PHP message: PHP Fatal error: Access level to Drupal\\charts_highcharts_drilldown\\Plugin\\views\\style\\ChartsDrilldownPluginStyleChart::getSelectedDataFields() must be protected

    Changed:
    line 235 in ChartsDrilldownPluginStyleChart.php
    from
    private function getSelectedDataFields(array $data_providers)
    to
    protected function getSelectedDataFields(array $data_providers): array
    as per this commit suggested above for the 1.0.0-dev version.

  • Pipeline finished with Skipped
    8 days ago
    #365054
  • 🇺🇸United States andileco
Production build 0.71.5 2024