- Issue created by @dieterholvoet
- π§πͺBelgium dieterholvoet Brussels
Never mind, the module isn't actually obsolete: it provides 'update/delete own' permissions that core doesn't provide. This means that we should create a new version that converts part of the permissions to the ones provided by core, while keeping the others in this module.
- π§πͺBelgium dieterholvoet Brussels
What we could do is log a message in the update hook in case no roles are using permissions provided by this module anymore, which means that the module can be removed.
- Merge request !7Add update hook to convert permissions to the new core permissions β (Merged) created by dieterholvoet
- Status changed to Needs review
about 1 month ago 12:26pm 25 February 2025 - π§πͺBelgium dieterholvoet Brussels
I implemented the update hook. I tried to let the update hook uninstall the module, but apparently that's not supported (yet): π Support uninstalling the module providing the update hook in hook_update_N Needs work .
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
This looks good to me - should we bother with an update test?
- π§πͺBelgium dieterholvoet Brussels
Writing tests is not my strong suit so I won't probably spend the time, but feel free if you want to.
- π§πͺBelgium dieterholvoet Brussels
We should probably also look into deprecating the outdated permissions. Since there isn't an official way to deprecate permissions yet (see π Provide a mechanism to deprecate permissions Needs work ), we could update the label/description.
- π§πͺBelgium dieterholvoet Brussels
Almost forgot, but we'll have to bump the minimum core version to 10.1.0 since that's when some of the permissions were added.
-
dieterholvoet β
committed 48cc00c6 on 8.x-1.x
Issue #3489678 by dieterholvoet, larowlan: Provide an upgrade path to...
-
dieterholvoet β
committed 48cc00c6 on 8.x-1.x