- Issue created by @jurgenhaas
- π¨πSwitzerland berdir Switzerland
I think this is similar to my notes in the multilingual meta issue about recipes needing to optionally integrate with each other? Not sure if the analytics reipes should depend on the privacy recipes, or vice versa.
Also, simpleConfigUpdate should not be used on config entities, there is an issue to block that. It might cause bugs, because doing so will bypass config entity hooks for example.
- πΊπΈUnited States phenaproxima Massachusetts
A reasonable solution for this particular case, I think, is to have the drupal_cms_analytics recipe depend on and apply the drupal_cms_privacy_basic recipe, explicitly import these two Klaro apps, and then set their status to TRUE.
So, a representative snippet of drupal_cms_analytics' recipe.yml:
recipes: - drupal_cms_privacy_basic install: - klaro config: import: klaro: - klaro.klaro_app.ga - klaro.klaro_app.gtm actions: klaro.klaro_app.ga: enable: [] klaro.klaro_app.gtm: enable: []
- π¦πΊAustralia pameeela
Agreed, I think it makes sense for GTM to depend on privacy.
- πΊπΈUnited States phenaproxima Massachusetts
Assigning to @dharizza for implementation when β¨ Add Google Tag recipe Active lands.
- π©πͺGermany jurgenhaas Gottmadingen
Something to consider, when addressing this to enable the consent management services for GA and GTM, is also the visibility of the consent management widget.
As a default, the privacy track has made that widget invisible, i.e. most users won't notice it, ever. This is suitable for most sites, as users find cookie banners and other widget annoying. For good reasons.
However, for GA and GTM, the priority might be different. If a site wants to track users, it is more interested in getting their consent. Therefore, it might be suitable to enable the widget to show to all users by default on those sites that apply the analytics recipe.
If that's the case, then the recipe should also enable that with this:
config: actions: klaro.settings: simpleConfigUpdate: dialog_mode: notice
- πΊπΈUnited States phenaproxima Massachusetts
The analytics recipe is in so this can now proceed.
- π©πͺGermany jan kellermann
FYI: The user generated callbacks will be blocked by CSP module.
Uncaught EvalError: Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src * 'unsafe-inline' 'report-sample'".
- First commit to issue fork.
- Merge request !275Enable privacy apps when applying the analytics recipe. β (Merged) created by dharizza
- πΊπΈUnited States phenaproxima Massachusetts
Looks straightforward, but a couple of things need to be changed.
- πΊπΈUnited States phenaproxima Massachusetts
Looks solid to me! Tests are passing, so I feel good about it.
-
phenaproxima β
committed 375a2e02 on 0.x authored by
dharizza β
Issue #3489649 by dharizza, phenaproxima, jurgenhaas, berdir: Enable...
-
phenaproxima β
committed 375a2e02 on 0.x authored by
dharizza β
- πΊπΈUnited States phenaproxima Massachusetts
Great privacy improvement! Merged into 0.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.