- Issue created by @a.dmitriiev
- Status changed to RTBC
about 2 months ago 8:10am 5 February 2025 - 🇬🇪Georgia jibla
Hi @a.dmitriiev
This issue needs more work. If you test this MR, you still can not install Gemini with recipes.
First, please move
install/gemini_provider.settings
file directly under config. Now in your MR its underconfig/scheme/install
.Second and most important, in order this to work from recipes, you must implement getSetupData() method in provider plugin implementation. You can check
ai_provider_openai
orai_provider_anthropic
for reference.Thanks for the contribution.
- 🇷🇴Romania vasike Ramnicu Valcea
@jibla ... of right ... sorry .. I just missed
I was working on my changes ... this included ... but I did my self not using the MRupdated the MR ... I hope we're good to go ... for now Needs Review
sorry again ...
- 🇩🇪Germany a.dmitriiev
Ooops, I haven't noticed that the file was in the wrong folder. Thanks @vasike for fixing it.
Regarding
getSetupData()
I will check it, but I am not sure that this is a requirement, as I am already using gemini_provider in the recipe and it works fine. I guess that method was added to those providers because of Drupal CMS integration. But I will check anyway. Thanks for pointing this out, @jibla. - 🇩🇪Germany a.dmitriiev
Ok, I see that config action
setupAiProvider
was added in AI module to use in recipes in case you have an API Key input. I will add the method to Gemini Provider. - 🇩🇪Germany a.dmitriiev
I have set
models/gemini-1.5-pro
as a default model. I am not sure whether it should be like this, any feedback would be appreciated. Anyway, this is just the default settings that can be changed any time. I believe that at the moment this would be the best model to use. -
jibla →
committed 311e7c00 on 1.x authored by
a.dmitriiev →
Issue #3489632 by a.dmitriiev, vasike, jibla: Add gemini_provider....
-
jibla →
committed 311e7c00 on 1.x authored by
a.dmitriiev →
- 🇬🇪Georgia jibla
@a.dmitriiev
@vasikeThank you guys, I think this is enough for this issue. I will merge this into 1.x and this will be part of the next release. You both will be credited.
- 🇬🇪Georgia jibla
@vasike - There is a typo of file name in your commit, but since I already merged it, I will fix it directly into 1.x now.
- 🇩🇪Germany a.dmitriiev
Let's also delete the wrongly named file from config/install folder. Please check my new MR
- 🇬🇪Georgia jibla
@a.dmitriiev - I am trying to merge it but get a strange error not merging. Will try later, if we can't merge from here, lets create a separate issue on this and merge separately.
-
jibla →
committed e1455efe on 1.x authored by
a.dmitriiev →
Issue #3489632 by a.dmitriiev, jibla, vasike: Add gemini_provider....
-
jibla →
committed e1455efe on 1.x authored by
a.dmitriiev →
Automatically closed - issue fixed for 2 weeks with no activity.