- Issue created by @pameeela
- 🇮🇳India shalini_jha
I have addressed the issue related to special characters by implementing the necessary fixes on both the project list page and the project detail modal. The issue has now been resolved, ensuring that special characters are handled correctly in both areas. Kindly review the changes.
project list page
→
project detail modal
https://www.drupal.org/files/issues/2024-12-04/Screenshot%20from%202024-... → - 🇺🇸United States chrisfromredfin Portland, Maine
I am unsure if we should be fixing this in the Svelte frontend or in the Middleware. I will ping Ben to get some opinions. Also, it's entirely possible we want to do both. Third, I'm not sure if we want to introduce a front-end dependency on HE or not.
I need more info.
- 🇮🇳India shalini_jha
Thank you for your review and feedback,
re based & fixed conflict. - 🇺🇸United States chrisfromredfin Portland, Maine
Per Ben in Slack:
Decoding should happen on the Back End, in as early a stage as possible after the data is received. The one exception is if there's some reason the non-decoded should be available
I think the approach we need, then, should actually be in the ProjectBrowserEndpointController.php before we return JSON to the Project Browser, or maybe the EnabledSourceHandler right when we get the response and before we put it in the KeyValueStore. Possibly we need to do this for each field that could contain HTML inside the individual sources.
- First commit to issue fork.
- 🇺🇸United States phenaproxima Massachusetts
One point of review, and I'm wondering if we might not want test coverage here somehow. Would that be reasonably straightforward to add?