- Issue created by @baltowen
- 🇩🇰Denmark ressa Copenhagen
Thanks! The patch adds a Configuration link on the Extend page as well as after installing the WP UI module:
[success] Module wordpress_migrate_ui has been installed. (Permissions - Configure)
The failing test looks unrelated. I tried running it again, but it still fails ¯\_(ツ)_/¯.
-
hongpong →
committed 3aa6b101 on 8.x-3.x authored by
baltowen →
Issue #3489324 by baltowen, ressa. Include link to configuration form in...
-
hongpong →
committed 3aa6b101 on 8.x-3.x authored by
baltowen →
- 🇺🇸United States hongpong Philadelphia
I've been updating the CI tests yesterday ( ✨ Update CI testing Active . However it will keep giving the red X until the Drupal 11 core compatible version of module is patched ( 📌 Automated Drupal 11 compatibility fixes for wordpress_migrate Needs review )
(or maybe if "lenient" gitlab CI settings are added.
However you can see the 'previous major' phpunit test is now added and it is green!
Looks good thank you for helping us tonight!! - 🇩🇰Denmark ressa Copenhagen
Thanks for working on the CI tests and getting the module Drupal 11 ready @hongpong!
PS. Please check the credit ... perhaps also in 🐛 Protocol "public" not supported Active :-)
- 🇺🇸United States hongpong Philadelphia
@ressa regarding the credits I thought it would credit baltowen as it is "authored by baltowen". I think it is possible to get more credits to the people supporting the issue and verifying the patch by 'rewriting the commit message' in the merge request interface though?
- 🇩🇰Denmark ressa Copenhagen
No, it has changed. You as maintainer need to actively enable credit for those who should get credited under "Credit & committing". The issue creator, patch creators, etc. are no longer automatically credited ... see #3226881: Do not automatically credit people who upload files to an issue → .
From this page about who should be credited and how: https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... → - and who to credit:
The following are examples of types of contributions that should be recognized:
- Creating a well-written issue that describes a problem
- Proposing a solution (either in the form of a patch, or a text comment)
- Reviewing or testing a patch
- Adding before/after screenshots of User Interface, styling, or other UI changes that have not already been posted by another user.
- Adding documentation
How to:
Check and uncheck the names of users listed in the box, depending on whether they contributed to moving the issue towards resolution. The credits will appear on the user and organization profiles when the issue status is changed to fixed, or when it automatically changes to closed fixed.
I believe that the right method would have been to check all the names under "Credit & committing" (baltowen for creating issue and patch, me for testing it, you for committing it) together with comment #6 where status was changed to "Fixed".
I think you can easily correct it by checking all names and clicking "Save" :)
- 🇺🇸United States hongpong Philadelphia
Oh wow I didn't know the checkbox states would save. I thought that gizmo just generated the commit messages to copy paste into git. Looks like it did work. Onwards!
- 🇩🇰Denmark ressa Copenhagen
Thanks @hongpong! As I commented in the other issue, I have updated the Granting credit to issue contributors → documentation page to make it less ambiguous.
Automatically closed - issue fixed for 2 weeks with no activity.