Referring the same entity multiple times breaks _referringItem

Looks like duplicate of

I don't think 🐛 Can only intentionally re-render an entity with references 20 times Needs work is a duplicate, but the two issues are closely related. I did notice that _referringItem would get overwritten while working on 🐛 Can only intentionally re-render an entity with references 20 times Needs work , and cloning the entity so that _referringItem is correct might actually help address recursion detection. Though I think in the (edge?) case where you are previewing new entities, cloning might make recursion detection more difficult, but I don't think that's a blocker here.

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

Thanks for the quick patch!

I suggested checking whether $entity->_referringItem exists first before cloning because I was afraid of the performance hit here.

MR is up with tests.

TY to @ghost of drupal past for the review. Replied to comments on the MR. I resolved the open threads, but please feel free to unresolve if they were not addressed satisfactorily.

Yes, sorry, I confused which entity is which. This looks good to me, thanks so much for the through tests and the quick resolution of all.

This is a tricky one, but tidy fix that makes sense and nice test coverage.

Committed/pushed to 11.x, cherry-picked to 11.1.x and 10.5.x, thanks!

catch → closed merge request !10299